chore: remove rc-util#143
Conversation
Walkthrough移除了构建配置中的 esm 别名映射；在 .gitignore 中新增忽略 dist/ 目录；在 package.json 中删除 rc-util 依赖。未更改导出或公共 API 声明。 Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 分钟 Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @yoyo837, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on streamlining the project's dependency tree by removing the rc-util package. This change involves updating the project's package.json to no longer list rc-util as a dependency and adjusting the build configuration to remove any specific handling for this package. Additionally, the .gitignore file was updated to properly exclude the dist directory from version control.
Highlights
- Dependency Removal: The
rc-utilpackage has been completely removed from the project's dependencies, as reflected in thepackage.jsonfile. - Build Configuration Update: The
.fatherrc.jsconfiguration file was updated to remove the alias specific torc-utilin the ESM build output, aligning with its removal. - Git Ignore Update: The
.gitignorefile was updated to include thedistdirectory, ensuring build output is not committed to the repository.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #143 +/- ##
=======================================
Coverage 80.00% 80.00%
=======================================
Files 6 6
Lines 670 670
Branches 164 165 +1
=======================================
Hits 536 536
Misses 134 134 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Code Review
This pull request correctly removes the unused rc-util dependency. The changes in package.json and .fatherrc.js are appropriate for this. I have one suggestion regarding the change in .gitignore to keep the pull request focused on a single concern, which improves the clarity of the commit history. Please see the detailed comment.
| .cache | ||
| *.css | ||
| build | ||
| dist |
There was a problem hiding this comment.
While adding dist to .gitignore is a good practice, this change is unrelated to the main purpose of this pull request, which is removing the rc-util dependency. To maintain a clean and understandable commit history, it's best practice to keep pull requests focused on a single logical change. Please consider moving this change to a separate pull request.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
package.json (1)
4-4: description 与包职能不符，建议修正当前描述像是从触发器组件复制过来，建议与 QRCode 组件对齐，避免 npm/搜索结果误导。
- "description": "base abstract trigger component for react", + "description": "React QRCode component.",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.fatherrc.js(0 hunks).gitignore(1 hunks)package.json(1 hunks)
💤 Files with no reviewable changes (1)
- .fatherrc.js
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Socket Security: Pull Request Alerts
🔇 Additional comments (3)
.gitignore (1)
25-25: 忽略 dist 👍与 dumi 文档站构建输出一致，且
files仅发布es/lib/assets，不会误发布 dist。无需额外改动。package.json (2)
6-6: 将 package.json 中 engines.node 从 ">=8.x" 升级为 ">=14.x"。
dumi 2 与 father 4 要求 Node.js >=14（参见 dumi 升级说明 & father 的 npm 页面），保留 ">=8.x" 会导致 CI/构建不兼容。
File: package.json (lines 6-6)
68-71: 移除 rc-util — 已核查，无残留引用，可安全移除已在源码（imports/requires）、package.json、锁文件（若存在）、以及常见构建配置文件 .fatherrc.js、jest.config.js、tsconfig.json（tsconfig 含 paths 字段）中搜索 rc-util 及子路径，未发现任何匹配。
2 participants
Summary by CodeRabbit