Skip to content

Commit

Permalink
feat: optimize code
Browse files Browse the repository at this point in the history
  • Loading branch information
kiner-tang committed Feb 18, 2024
1 parent b34469b commit 8ed1db8
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 7 deletions.
3 changes: 1 addition & 2 deletions src/Footer/SummaryContext.tsx
Original file line number Diff line number Diff line change
@@ -1,13 +1,12 @@
import * as React from 'react';
import type { ColumnsType, ColumnType, StickyOffsets } from '../interface';
import type { ColumnType, StickyOffsets } from '../interface';

type FlattenColumns<RecordType> = readonly (ColumnType<RecordType> & { scrollbar?: boolean })[];

const SummaryContext = React.createContext<{
stickyOffsets?: StickyOffsets;
scrollColumnIndex?: number;
flattenColumns?: FlattenColumns<any>;
columns?: ColumnsType<any>;
}>({});

export default SummaryContext;
8 changes: 3 additions & 5 deletions src/Footer/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { useContext } from '@rc-component/context';
import * as React from 'react';
import TableContext, { responseImmutable } from '../context/TableContext';
import devRenderTimes from '../hooks/useRenderTimes';
import type { ColumnsType, ColumnType, StickyOffsets } from '../interface';
import type { ColumnType, StickyOffsets } from '../interface';
import Summary from './Summary';
import SummaryContext from './SummaryContext';

Expand All @@ -12,15 +12,14 @@ export interface FooterProps<RecordType> {
children: React.ReactNode;
stickyOffsets: StickyOffsets;
flattenColumns: FlattenColumns<RecordType>;
columns: ColumnsType<RecordType>;
}

function Footer<RecordType>(props: FooterProps<RecordType>) {
if (process.env.NODE_ENV !== 'production') {
devRenderTimes(props);
}

const { children, stickyOffsets, flattenColumns, columns } = props;
const { children, stickyOffsets, flattenColumns } = props;

const prefixCls = useContext(TableContext, 'prefixCls');

Expand All @@ -32,9 +31,8 @@ function Footer<RecordType>(props: FooterProps<RecordType>) {
stickyOffsets,
flattenColumns,
scrollColumnIndex: scrollColumn?.scrollbar ? lastColumnIndex : null,
columns,
}),
[scrollColumn, flattenColumns, lastColumnIndex, stickyOffsets, columns],
[scrollColumn, flattenColumns, lastColumnIndex, stickyOffsets],
);

return (
Expand Down

0 comments on commit 8ed1db8

Please sign in to comment.