Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rowHoverable to disable hover interaction #1068

Merged
merged 6 commits into from
Mar 26, 2024

Conversation

madocto
Copy link
Contributor

@madocto madocto commented Jan 19, 2024

Copy link

vercel bot commented Jan 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
table ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2024 9:00am

@madocto madocto changed the title feat feat: add disabledHover to disable hover styles Jan 19, 2024
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.96%. Comparing base (a456130) to head (8cc03cc).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1068   +/-   ##
=======================================
  Coverage   97.96%   97.96%           
=======================================
  Files          51       51           
  Lines        4661     4671   +10     
  Branches      590      592    +2     
=======================================
+ Hits         4566     4576   +10     
  Misses         91       91           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163
Copy link
Member

afc163 commented Jan 20, 2024

命名为 rowHoverable 感觉更合适一点。

@madocto madocto changed the title feat: add disabledHover to disable hover styles feat: add rowHoverable to disable hover interaction Jan 20, 2024
@madocto madocto force-pushed the feat-disabled-hover branch from 051d3de to 15c38ca Compare January 22, 2024 00:03
@zombieJ zombieJ merged commit a1aae13 into react-component:master Mar 26, 2024
9 checks passed
@@ -117,6 +117,7 @@ React.render(<Table columns={columns} data={data} />, mountNode);
| components | Object | | Override table elements, see [#171](https://github.com/react-component/table/pull/171) for more details |
| sticky | boolean \| {offsetHeader?: number, offsetScroll?: number, getContainer?: () => Window \| HTMLElement } | false | stick header and scroll bar |
| summary | (data: readonly RecordType[]) => React.ReactNode | - | `summary` attribute in `table` component is used to define the summary row. |
| rowHoverable | boolean | true | Table hover interaction |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
这个命名对吗?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants