fix: solve fixed column's shadow display unexpected issue #1081
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1081 +/- ##
===========================================
+ Coverage 50.25% 92.65% +42.40%
===========================================
Files 97 53 -44
Lines 9072 4902 -4170
Branches 633 590 -43
===========================================
- Hits 4559 4542 -17
+ Misses 4463 354 -4109
+ Partials 50 6 -44 ☔ View full report in Codecov by Sentry. |
|
佬，不用搞个测试用例吗？ |
要的，我加一个 |
|
看上去是完整撤回 #925 的改动，再调整了一下
是否会重新导致 ant-design/ant-design#39880 |
是换了一种方式去判断和实现，在测试用例里面已经有测试过 ant-design/ant-design#39880 这种情况的了 |
那就剩下 SummaryContext 的 columns 没有撤回，我看没有在用了 |
恩恩，确实是这里漏改了，我改一下 |
| const canLastFix = | ||
| (nextColumn && nextColumn.fixed === undefined) || | ||
| (prevColumn && prevColumn.fixed === undefined) || | ||
| columns.every(col => col.fixed === 'left'); |
There was a problem hiding this comment.
这里是在处理这种情况，
(nextColumn && nextColumn.fixed === undefined) ||
(prevColumn && prevColumn.fixed === undefined) ||上面这两行时处理 left 和 right 的情况
| @@ -6,8 +6,12 @@ export default defineConfig({ | |||
| }, | |||
| test: { | |||
| include: ['**/tests/*.spec.*'], | |||
| exclude: ['**/coverage/**'], | |||
There was a problem hiding this comment.
是指跑不了覆盖率测试吗？我记得当时如果不加这个的话，好像默认还会测试这里面的一些文件
fix ant-design/ant-design#47374