Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix-coverage #1100

Closed
wants to merge 1 commit into from
Closed

Conversation

linxianxi
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Apr 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
table ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2024 9:24am

...state,
isHiddenScrollBar: false,
}));
}
Copy link
Member

@afc163 afc163 Apr 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不建议这样修 ci 覆盖率,原来的格式缩进格式更好维护。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

貌似是因为加了 raf 所以走不到 return 里了,但是为了保险还是加个 if 判断下 scrollBodyRef.current

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.01%. Comparing base (80c86bf) to head (a0f5239).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1100      +/-   ##
==========================================
+ Coverage   97.97%   98.01%   +0.04%     
==========================================
  Files          51       51              
  Lines        4680     4679       -1     
  Branches      594      593       -1     
==========================================
+ Hits         4585     4586       +1     
+ Misses         91       89       -2     
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@linxianxi linxianxi requested a review from afc163 April 2, 2024 09:30
@linxianxi linxianxi closed this Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants