Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apple): read Gemfile & fallback to globally installed pod #2629

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

szymonrybczak
Copy link
Collaborator

Summary

Some projects have Gemfile in the root directory but for other purposes, so checking if it's presented is not enough.

This Pull Request adds reading and simple regex to check if gem cocoapods is included which should make the workflow more solid.

Also this Pull Requests adds a fallback if for any reason CLI decided to install with bundle exec pod install we fail silently and fallback to globally installed pod.

Test Plan

  1. yarn add react-native-svg
  2. Remove Gemfile and run run-ios
  3. Cocoapods should be properly installed.

Checklist

  • Documentation is up to date.
  • Follows commit message convention described in CONTRIBUTING.md.
  • For functional changes, my test plan has linked these CLI changes into a local react-native checkout (instructions).

@szymonrybczak szymonrybczak requested a review from thymikee as a code owner March 8, 2025 17:22
@szymonrybczak
Copy link
Collaborator Author

cc @tido64 I hope that with this one we'll finally make everything work in your setup 🤞

@szymonrybczak szymonrybczak changed the title fix: read Gemfile & fallback to globally installed pod fix(apple): read Gemfile & fallback to globally installed pod Mar 8, 2025
@github-actions github-actions bot added the bugfix label Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant