Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix issue with AppName stripping incorrectly.
Browse files Browse the repository at this point in the history
Handles cases where appName is empty.
blakef committed Feb 26, 2024
1 parent b6bbf79 commit cca3815
Showing 2 changed files with 20 additions and 1 deletion.
19 changes: 19 additions & 0 deletions src/__tests__/utils.spec.ts
Original file line number Diff line number Diff line change
@@ -2,6 +2,7 @@ import { PACKAGE_NAMES } from '../constants'
import '../releases/__mocks__/index'
import {
getVersionsContentInDiff,
removeAppPathPrefix,
replaceAppDetails,
getChangelogURL,
} from '../utils'
@@ -132,3 +133,21 @@ describe('replaceAppDetails ', () => {
}
)
})

describe('removeAppPathPrefix', () => {
test.each([
['RnDiffApp/package.json', 'package.json'],
['RnDiffApp/RnDiffApp.ts', 'RnDiffApp.ts'],
])('removeAppPathPrefix("%s") -> "%s"', (path, newPath) => {
expect(removeAppPathPrefix(path)).toEqual(newPath)
})

test('removeAppPathPrefix custom AppName', () => {
expect(removeAppPathPrefix('RnDiffApp/package.json', '')).toEqual(
'RnDiffApp/package.json'
)
expect(removeAppPathPrefix('Foobar/package.json', 'Foobar')).toEqual(
'package.json'
)
})
})
2 changes: 1 addition & 1 deletion src/utils.ts
Original file line number Diff line number Diff line change
@@ -75,7 +75,7 @@ export const getBinaryFileURL = ({
}

export const removeAppPathPrefix = (path: string, appName = DEFAULT_APP_NAME) =>
path.replace(new RegExp(`${appName}/`), '')
path.replace(new RegExp(`^${appName}/`), '')

/**
* Replaces DEFAULT_APP_PACKAGE and DEFAULT_APP_NAME in str with custom

0 comments on commit cca3815

Please sign in to comment.