adjust Japanese translations to make more understandable, fix country…#10
Open
MichaelCharles wants to merge 1 commit intoreact-pdf-viewer:mainfrom
Open
adjust Japanese translations to make more understandable, fix country…#10MichaelCharles wants to merge 1 commit intoreact-pdf-viewer:mainfrom
MichaelCharles wants to merge 1 commit intoreact-pdf-viewer:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…/language code
The Japanese related to "Page Width" and "Page Fit" was confusing for my colleagues, and so I've updated it to something more understandable.
Also, the same as for English we do "en_US", language code first, and then country code, for Japanese it ought to be, "ja_JP", where ja designates "Japanese" and JP designates "Japan." Unfortunately, moving the file will be a breaking change for anyone using the previous version, so I'm not sure what the best way to proceed is here.