reactchartjs · renovate · Jan 1, 2025
diff --git a/package.json b/package.json
@@ -62,9 +62,9 @@
     "react": "^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0"
   },
   "devDependencies": {
-    "@commitlint/cli": "^17.0.0",
-    "@commitlint/config-conventional": "^17.0.0",
-    "@commitlint/cz-commitlint": "^17.0.0",
+    "@commitlint/cli": "^19.0.0",
+    "@commitlint/config-conventional": "^19.0.0",
+    "@commitlint/cz-commitlint": "^19.0.0",
     "@rollup/plugin-node-resolve": "^16.0.0",
     "@size-limit/preset-big-lib": "^11.1.6",
     "@storybook/addon-actions": "^8.4.7",

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/src/chart.tsx b/src/chart.tsx
    if (!redraw && chartRef.current && data.datasets) {
      setDatasets(chartRef.current.config.data, data.datasets, datasetIdKey);
    }
  }, [redraw, data.datasets]);

  useEffect(() => {
    if (!chartRef.current) return;
    } else {
      chartRef.current.update(updateMode);
    }
  }, [redraw, options, data.labels, data.datasets, updateMode]);

  useEffect(() => {
    if (!chartRef.current) return;

    destroyChart();
    setTimeout(renderChart);
  }, [type]);

  useEffect(() => {
    renderChart();

    return () => destroyChart();
  }, []);

  return (
    <canvas
diff --git a/stories/Chart.stories.tsx b/stories/Chart.stories.tsx
              xMin: 1,
              xMax: 2,
              yMin: 50,
              yMax: yMax,
              backgroundColor: 'rgba(255, 99, 132, 0.25)',
            },
          },
	if (!redraw && chartRef.current && data.datasets) {
	setDatasets(chartRef.current.config.data, data.datasets, datasetIdKey);
	}
	}, [redraw, data.datasets]);
Check warning on line 76 in src/chart.tsx GitHub Actions / Tests `React Hook useEffect has a missing dependency: 'datasetIdKey'. Either include it or remove the dependency array`

	useEffect(() => {
	if (!chartRef.current) return;
	} else {
	chartRef.current.update(updateMode);
	}
	}, [redraw, options, data.labels, data.datasets, updateMode]);
Check warning on line 87 in src/chart.tsx GitHub Actions / Tests `React Hook useEffect has missing dependencies: 'destroyChart' and 'renderChart'. Either include them or remove the dependency array`

	useEffect(() => {
	if (!chartRef.current) return;

	destroyChart();
	setTimeout(renderChart);
	}, [type]);
Check warning on line 94 in src/chart.tsx GitHub Actions / Tests `React Hook useEffect has missing dependencies: 'destroyChart' and 'renderChart'. Either include them or remove the dependency array`

	useEffect(() => {
	renderChart();

	return () => destroyChart();
	}, []);
Check warning on line 100 in src/chart.tsx GitHub Actions / Tests `React Hook useEffect has missing dependencies: 'destroyChart' and 'renderChart'. Either include them or remove the dependency array`

	return (
	<canvas
	xMin: 1,
	xMax: 2,
	yMin: 50,
	yMax: yMax,
Check warning on line 178 in stories/Chart.stories.tsx GitHub Actions / Tests `Expected property shorthand`
	backgroundColor: 'rgba(255, 99, 132, 0.25)',
	},
	},