Add polyfills and centralize null checks#489
Merged
Merged
Conversation
Use ArgumentNullException.ThrowIfNull on .NET 8 builds while keeping explicit null-checks for older frameworks across FusilladeSplatBuilderExtensions, NetCache, and RateLimitedHttpMessageHandler to standardize parameter validation. Bump ReactiveUI and ReactiveUI.Testing to 23.1.1 and adjust a test to use RxSchedulers.TaskpoolScheduler (HttpSchedulerSharedTests). Modified files: Directory.Packages.props, Fusillade.Tests/Http/HttpSchedulerSharedTests.cs, Fusillade/Builder/FusilladeSplatBuilderExtensions.cs, Fusillade/NetCache.cs, Fusillade/RateLimitedHttpMessageHandler.cs.
Introduce argument validation helper and multiple polyfills to improve compatibility across .NET targets. Added ArgumentExceptionHelper to centralize ThrowIfNull/ThrowIfNullOrEmpty usage and replaced platform-specific guards in FusilladeSplatBuilderExtensions, NetCache, RateLimitedHttpMessageHandler, and other places to use the helper. Add polyfill types (CallerArgumentExpressionAttribute, HashCode for .NET Framework, IsExternalInit, NotNullAttribute, RequiresDynamicCodeAttribute, RequiresUnreferencedCodeAttribute) under src/Fusillade/Polyfills to provide missing APIs on older runtimes or forward to framework types when available. Also update copyright headers and stylecop.json copyright range to 2016 - 2026.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Update
What is the new behavior?
Introduce argument validation helper and multiple polyfills to improve compatibility across .NET targets.
Added ArgumentExceptionHelper to centralize ThrowIfNull/ThrowIfNullOrEmpty usage and replaced platform-specific guards in FusilladeSplatBuilderExtensions, NetCache, RateLimitedHttpMessageHandler, and other places to use the helper.
Add polyfill types (CallerArgumentExpressionAttribute, HashCode for .NET Framework, IsExternalInit, NotNullAttribute, RequiresDynamicCodeAttribute, RequiresUnreferencedCodeAttribute) under src/Fusillade/Polyfills to provide missing APIs on older runtimes or forward to framework types when available.
Also update copyright headers and stylecop.json copyright range to 2016 - 2026.