refactor: replace System.Reactive with ReactiveUI.Primitives - #2152
Merged
Conversation
…grate observable test helpers Removed `System.Reactive` in favor of `ReactiveUI.Primitives`, updated dependencies, and refactored related test and observable functionalities using new helpers.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2152 +/- ##
==========================================
+ Coverage 97.56% 97.63% +0.07%
==========================================
Files 112 110 -2
Lines 5334 5292 -42
Branches 961 959 -2
==========================================
- Hits 5204 5167 -37
+ Misses 31 28 -3
+ Partials 99 97 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ChrisPulman
approved these changes
Jun 22, 2026
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Refactor
What is the new behavior?
The
System.Reactivedependency has been replaced withReactiveUI.Primitives. Observables and related test functionalities have been refactored to utilize the new helpers.What is the current behavior?
System.Reactiveis used for reactive functionality.What might this PR break?
Nothing. System.Reactive was purely a internal class. Perhaps the R3 generators.