Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to "Optimizing Performance" page in "Render and Commit" #856

Merged
merged 3 commits into from
Feb 21, 2024
Merged

Fix link to "Optimizing Performance" page in "Render and Commit" #856

merged 3 commits into from
Feb 21, 2024

Conversation

pwbriggs
Copy link
Contributor

@pwbriggs pwbriggs commented Feb 2, 2024

Closes reactjs/react.dev#6603.

Fix a link in "Render and Commit" ("렌더링 그리고 커밋"). Currently, the link points to a non-existent /learn/performance page. This makes it link to the legacy docs page "Optimizing Performance" ("성능 최적화") instead, like English react.dev does.

Copy link

vercel bot commented Feb 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
ko-legacy-reactjs-org ⬜️ Ignored (Inspect) Visit Preview Feb 19, 2024 0:41am

Copy link

github-actions bot commented Feb 5, 2024

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@@ -142,7 +142,7 @@ img { margin: 0 10px 10px 0; }

#### Optimizing performance {/*optimizing-performance*/}

업데이트된 컴포넌트 내에 중첩된 모든 컴포넌트를 렌더링하는 기본 동작은 업데이트된 컴포넌트가 트리에서 매우 높은 곳에 있는 경우 성능 최적화되지 않습니다. 성능 문제가 발생하는 경우 [성능](/learn/performance) 섹션에 설명된 몇 가지 옵트인 방식으로 문제를 해결 할 수 있습니다. **성급하게 최적화하지 마세요!**
업데이트된 컴포넌트 내에 중첩된 모든 컴포넌트를 렌더링하는 기본 동작은 업데이트된 컴포넌트가 트리에서 매우 높은 곳에 있는 경우 성능 최적화되지 않습니다. 성능 문제가 발생하는 경우 [성능](https://ko.legacy.reactjs.org/docs/optimizing-performance.html) 섹션에 설명된 몇 가지 옵트인 방식으로 문제를 해결 할 수 있습니다. **성급하게 최적화하지 마세요!**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요거 레거시 링크로 넣으신 이유가 있을까요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know of any relevant page in the new documentation. I just linked to the translation of the same (legacy) page that English react.dev does.

@hg-pyun hg-pyun merged commit 733448c into reactjs:main Feb 21, 2024
5 checks passed
@pwbriggs pwbriggs deleted the patch-1 branch February 21, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not found(ko.react.dev)
2 participants