Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate: what weve been working on february 2024 #900

Merged
merged 7 commits into from
May 20, 2024
Merged

Translate: what weve been working on february 2024 #900

merged 7 commits into from
May 20, 2024

Conversation

shyuuuuni
Copy link
Contributor

@vercel Vercel
Copy link

vercel bot commented Apr 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
ko-legacy-reactjs-org ⬜️ Ignored (Inspect) Visit Preview May 14, 2024 4:22am

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 28, 2024 •
edited
Loading

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

hg-pyun
hg-pyun approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@hg-pyun hg-pyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

기여 감사합니다!

hg-pyun
hg-pyun requested changes Apr 29, 2024
View reviewed changes
Copy link
Member

@hg-pyun hg-pyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JavaScript와 자바스크립트 표기가 혼용되고 있는데, 하나로 통일하면 좋을 것 같습니다.

@shyuuuuni
Copy link
Contributor Author

JavaScript와 자바스크립트 표기가 혼용되고 있는데, 하나로 통일하면 좋을 것 같습니다.

리뷰 감사합니다! 제안해주신 Javascript 오타 커밋 반영 및 자바스크립트로 미번역한 용어 번역했습니다. 👍

@hg-pyun
Copy link
Member

hg-pyun commented May 12, 2024

@shyuuuuni 휴가가 길어서 리뷰가 늦었습니다 🙇‍♂️ 컨플릭트 한번 풀어주실 수 있으실까요?

@shyuuuuni
Copy link
Contributor Author

shyuuuuni commented May 14, 2024 •
edited
Loading

@shyuuuuni 휴가가 길어서 리뷰가 늦었습니다 🙇‍♂️ 컨플릭트 한번 풀어주실 수 있으실까요?

@hg-pyun 오 넵넵 아래 변경사항 확인하고 반영했습니다!

  • 포스트 설명 추가
  • 훅 이름 변경 반영 (useFormState -> useActionState)
  • 'use server' 및 'use client' 라우팅 변경 (/react -> /rsc)

@hg-pyun hg-pyun merged commit 7caf116 into reactjs:main May 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hg-pyun hg-pyun hg-pyun approved these changes

@gnujoow gnujoow gnujoow approved these changes

@taehwanno taehwanno Awaiting requested review from taehwanno

@simsim0709 simsim0709 Awaiting requested review from simsim0709

@b9words b9words Awaiting requested review from b9words

@taggon taggon Awaiting requested review from taggon

@MaxKim-J MaxKim-J Awaiting requested review from MaxKim-J

@eomttt eomttt Awaiting requested review from eomttt eomttt is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shyuuuuni @hg-pyun @gnujoow