Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refactor Accordion component to use state hook for panel activation #7007

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/content/learn/sharing-state-between-components.md
Original file line number Diff line number Diff line change
Expand Up @@ -133,27 +133,29 @@ In this example, it's the `Accordion` component. Since it's above both panels an
import { useState } from 'react';

export default function Accordion() {
const [isActive, setIsActive] = useState(false);

return (
<>
<h2>Almaty, Kazakhstan</h2>
<Panel title="About" isActive={true}>
<Panel title="About" isActive={isActive} onShow={() => setIsActive(true)}>
With a population of about 2 million, Almaty is Kazakhstan's largest city. From 1929 to 1997, it was its capital city.
</Panel>
<Panel title="Etymology" isActive={true}>
<Panel title="Etymology" isActive={isActive} onShow={() => setIsActive(true)}>
The name comes from <span lang="kk-KZ">алма</span>, the Kazakh word for "apple" and is often translated as "full of apples". In fact, the region surrounding Almaty is thought to be the ancestral home of the apple, and the wild <i lang="la">Malus sieversii</i> is considered a likely candidate for the ancestor of the modern domestic apple.
</Panel>
</>
);
}

function Panel({ title, children, isActive }) {
function Panel({ title, children, isActive, onShow }) {
return (
<section className="panel">
<h3>{title}</h3>
{isActive ? (
<p>{children}</p>
) : (
<button onClick={() => setIsActive(true)}>
<button onClick={onShow}>
Show
</button>
)}
Expand Down
Loading