docs: Remove unused onAddTask prop and useContext imports from reducer + context example#8427
docs: Remove unused onAddTask prop and useContext imports from reducer + context example#8427danrday wants to merge 1 commit intoreactjs:mainfrom
onAddTask prop and useContext imports from reducer + context example#8427Conversation
AddTask no longer needs an onAddTask prop or useContext now that the component reads dispatch directly from context via useTasksDispatch.
|
Hi @danrday! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
onAddTask prop and useContext importsonAddTask prop and useContext imports from reducer + context example
Size changesDetails📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
AddTask no longer needs an
onAddTaskprop oruseContextnow that the component reads dispatch directly from context viauseTasksDispatch.onAddTaskprop fromAddTask- the component usesuseTasksDispatch()directly, so no handler needs to be passed downuseContextimport from bothAddTask.jsandTaskList.js- the custom hooks (useTasksDispatch,useTasks)already encapsulate the context calls
No behavior change. This makes the example consistent with the
surrounding explanation, which highlights that context lets child
components skip prop-passing entirely.