This repository was archived by the owner on May 7, 2025. It is now read-only.
AN-8888: Normalize the uri before loading data in EpubServer #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I reviewed the code "on paper" (i.e. I did not try it myself with edge cases such as HTML escape entities in URL syntax), and it all makes sense, PR looks safe to merge. However I hope others will review / test the code too :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a URI contains HTML URL encoding will cause EpubServer fails to load that resource. This patch will normalize URL(s) before loading to resolve URI cannot be loaded in EpubServer.