Improve JSON marshaling of a11y metadata#290
Open
naglis wants to merge 5 commits intoreadium:developfrom
Open
Conversation
naglis
commented
Feb 3, 2026
| // A11yPrimaryAccessMode is a human primary sensory perceptual system or cognitive faculty through which a person may process or perceive information. | ||
| type A11yPrimaryAccessMode string | ||
|
|
||
| type A11yPrimaryAccessModeList [][]A11yPrimaryAccessMode |
Contributor
Author
There was a problem hiding this comment.
Not sure about the type name since it is a list of lists. Would welcome suggestions.
This is needed to have a custom `MarshalJSON` implementation to marshal e.g. `["textual"]` as `"textual"`. Addresses readium#281
This implementation allows to render a profile list of a single value as a string. Addresses readium#281
The expected result changed after adding a custom `MarshalJSON` to `A11yProfileList` to marshal a single value as a string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #281.