Handle URLs with aliases in ExplodedArchive
#441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickael-menu
approved these changes
May 29, 2024
There was a problem hiding this comment.
Thanks @domkm!
However, I don't know how to make resolvingSymlinks async without creating the need for a very significant rewrite since it would cause ExplodedArchive to need to be async
No problem, I'll adjust when migrating the other APIs to async.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #434
As you requested, I separated
resolvingSymlinksfromisParent. However, I don't know how to makeresolvingSymlinksasync without creating the need for a very significant rewrite since it would causeExplodedArchiveto need to be async, which would in turn cause those callers to need to be async, etc.