Fix multiple tap events broadcasted on macOS #587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the issue of multiple tap events being broadcasted on macOS by refactoring the tap gesture handling in the EPUB navigator. The key changes include:
- Enabling/disabling the shared tap gesture recognizer based on the navigator's state.
- Refactoring to use a lazy-instantiated tap gesture recognizer instead of creating a new instance during view loading.
- Updating the CHANGELOG accordingly.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Sources/Navigator/EPUB/EPUBNavigatorViewController.swift | Refactored gesture handling to prevent duplicate events. |
| Sources/Internal/Measure.swift | Added utility functions for measuring execution time. |
| CHANGELOG.md | Updated changelog to reflect tap event fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
Navigator