Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes a variety of deprecated APIs throughout the codebase to streamline the interface and enforce the new async and migration patterns. Key changes include:
- Removal of deprecated properties, functions, and typealiases from Publication, Navigator, and LCP-related modules.
- Complete removal of unused files such as PublicationAsset.swift, FileAsset.swift, UserSettings.swift, and LCPAcquisition.swift.
- Replacement of synchronous APIs with asynchronous variants and updated usage patterns.
Reviewed Changes
Copilot reviewed 53 out of 53 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Sources/Shared/Publication/Link.swift | Removed deprecated property and copy methods to enforce the new API usage. |
| Sources/Shared/Publication/Asset/PublicationAsset.swift | Removed the deprecated PublicationAsset protocol and its dependencies. |
| Sources/Shared/Publication/Asset/FileAsset.swift | Removed the legacy file-based asset representation. |
| Sources/Shared/Logger/Logger.swift | Removed the deprecated logging function in favor of the updated log initializer. |
| Sources/Navigator/VisualNavigator.swift | Removed deprecated extensions and alias methods, promoting the async variants. |
| Sources/Navigator/TTS/TTSEngine.swift | Removed the synchronous speak API in favor of its async variant. |
| Sources/Navigator/TTS/AVTTSEngine.swift | Removed the legacy init with audio session configuration. |
| Sources/Navigator/PDF/PDFNavigatorViewController.swift | Removed deprecated PDF view customization method. |
| Sources/Navigator/Navigator.swift | Removed synchronous navigation methods to standardize async navigation. |
| Sources/Navigator/EditingAction.swift | Removed deprecated alias for defining actions. |
| Sources/Navigator/EPUB/UserSettings.swift | Removed the legacy user settings API to support the new Preferences API. |
| Sources/Navigator/EPUB/EPUBNavigatorViewModel.swift | Removed the deprecated convenience initializer in favor of the designated initializer. |
| Sources/Navigator/EPUB/EPUBNavigatorViewController.swift | Removed deprecated properties and functions related to user settings and evaluation APIs. |
| Sources/Navigator/CBZ/CBZNavigatorViewController.swift | Removed deprecated initializers and property aliases for CBZ publications. |
| Sources/Navigator/Audiobook/AudioNavigator.swift | Removed deprecated typealiases for audio navigation. |
| Sources/LCP/License/Model/Components/Link.swift | Removed deprecated URL expansion API, now using url() instead. |
| Sources/LCP/LCPService.swift | Removed an outdated initializer and related functions that conflict with the new migration guide. |
| Sources/LCP/LCPLicense.swift | Removed deprecated loan renewal and return APIs in favor of async variants. |
| Sources/LCP/LCPAcquisition.swift | Removed the entire legacy acquisition API file. |
| Sources/Adapters/GCDWebServer/GCDHTTPServer.swift | Removed the deprecated shared instance, encouraging users to create their own instances. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.