fix: don't attempt to validate OpenAPI 3.2 definitions (for now) #1008
+51
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanadgupta
reviewed
Oct 13, 2025
| * @returns If the definition is a 3.0 definition. | ||
| */ | ||
| export function isOAS30(check: OpenAPIV3_1.Document | OpenAPIV3.Document): check is OpenAPIV3.Document { | ||
| return check.openapi.startsWith('3.0'); |
There was a problem hiding this comment.
i think this needs a few more typeguards in order to get tests passing:
Suggested change
| return check.openapi.startsWith('3.0'); | |
| return 'openapi' in check && check.openapi !== undefined && check.openapi.startsWith('3.0'); |
There was a problem hiding this comment.
we should make the same change to isOAS31 because I just copied it across.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
We currently do not support OpenAPI 3.2 so we should not allow any 3.2 API definitions to be validated as they will fail due to our parser internals attempting to validate them as 3.0.