test(openapi/validate): rewrite tests to be more comprehensive #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanadgupta
added
refactor
kanadgupta
commented
Mar 5, 2025
| }); | ||
|
|
||
| beforeEach(() => { | ||
| consoleInfoSpy = vi.spyOn(console, 'info').mockImplementation(() => {}); |
There was a problem hiding this comment.
we were previously handrolling mocks for console.info in addition to the console output mocking we get via @oclif/test. what a mess
erunion
approved these changes
Mar 5, 2025
| @@ -148,22 +121,15 @@ describe('rdme openapi validate', () => { | |||
| }); | |||
|
|
|||
| it('should create GHA workflow if user passes in spec via prompts', async () => { | |||
| expect.assertions(6); | |||
| expect.assertions(3); | |||
There was a problem hiding this comment.
should we bother with expect.assertions at all?
There was a problem hiding this comment.
yeah i went back and forth here, they do seem unnecessary. i'll remove 'em
This was referenced Mar 5, 2025
|
🎉 This PR is included in version 10.2.0-next.5 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
kanadgupta
added a commit
that referenced
this pull request
Mar 5, 2025
## 🧰 Changes continuing my work in #1188 with even more work to migrate over our tests to the more comprehensive `runCommand` helper: - [x] `openapi convert` - [x] `openapi inspect` - [x] `openapi reduce` - [x] `login` - [x] `logout` - [x] `whoami` the only outstanding tests using the now deprecated `runCommandAndReturnResult` helper are the changelog tests, but i'll swap those out if/when we get around to migrating that command over to APIv2. ## 🧬 QA & Testing no functional changes. do tests still pass?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
rewrites our tests for
openapi validateto be more compliant with our contributing guidelines. i initially wrote them this way to minimize the amount of legwork to getoclifworking but this approach to testing is far more comprehensive and it should be much easier to drop in stray console logs for debugging purposes.🧬 QA & Testing
do tests still pass?