Skip to content

Fix a flaky test relying on azure storage #1204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidfischer merged 1 commit into from
Apr 14, 2026
Merged

Fix a flaky test relying on azure storage #1204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions adserver/tests/data/bulk_ad_upload.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Name,Live,Link URL,Image URL,Headline,Content,Call to Action
Ad1,true,http://example.com/ad1,https://ethicalads.blob.core.windows.net/media/images/2022/11/ethicalads-housead.png,Ad headline,"Ad content",Ad CTA
Ad2,true,http://example.com/ad2,https://ethicalads.blob.core.windows.net/media/images/2022/11/ethicalads-housead.png,Ad headline2,"Ad content2",Ad CTA2
Ad1,true,http://example.com/ad1,https://media.ethicalads.io/images/2022/11/ethicalads-housead.png,Ad headline,"Ad content",Ad CTA
Ad2,true,http://example.com/ad2,https://media.ethicalads.io/images/2022/11/ethicalads-housead.png,Ad headline2,"Ad content2",Ad CTA2
2 changes: 1 addition & 1 deletion adserver/tests/data/bulk_ad_upload_invalid.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Name,Live,Link URL,Image URL,Headline,Content,Call to Action
Invalid Ad1,true,http://example.com/ad1,https://ethicalads.blob.core.windows.net/media/images/2022/11/ethicalads-housead.png,Ad headline,"Ad content that is so long that it will raise an error since it's too long and there's a maximum",Ad CTA
Invalid Ad1,true,http://example.com/ad1,https://media.ethicalads.io/images/2022/11/ethicalads-housead.png,Ad headline,"Ad content that is so long that it will raise an error since it's too long and there's a maximum",Ad CTA
Loading