Pin prompt-toolkit>=3.0.43 to fix TypeError on Python 3.12#1206
Draft
ericholscher wants to merge 1 commit intomainfrom
Draft
Pin prompt-toolkit>=3.0.43 to fix TypeError on Python 3.12#1206ericholscher wants to merge 1 commit intomainfrom
ericholscher wants to merge 1 commit intomainfrom
Conversation
Older versions of prompt-toolkit pass bare coroutines to asyncio.wait() which raises TypeError on Python 3.12+. This is a transitive dependency via celery -> click-repl.
davidfischer
approved these changes
Apr 15, 2026
Collaborator
davidfischer
left a comment
There was a problem hiding this comment.
I built the image and verified celery started and ran correctly with this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prompt-toolkitpass bare coroutines toasyncio.wait(), which raisesTypeErroron Python 3.12+ (coroutines were deprecated in 3.8, became an error in 3.12)prompt-toolkitis a transitive dependency viacelery→click-replprompt-toolkit>=3.0.43which wraps coroutines withensure_future()before passing toasyncio.wait()Error
Test plan
TypeErroron Python 3.12