Skip to content

Project: show search settings in separate form#709

Merged
stsewd merged 2 commits intomainfrom
show-search-settings
Apr 13, 2026
Merged

Project: show search settings in separate form#709
stsewd merged 2 commits intomainfrom
show-search-settings

Conversation

@stsewd
Copy link
Copy Markdown
Member

@stsewd stsewd commented Mar 12, 2026

@stsewd stsewd requested a review from a team as a code owner March 12, 2026 23:48
@stsewd stsewd requested a review from agjohnson March 12, 2026 23:48
{% load crispy from crispy_forms_tags %}

{% block title %}
{% trans "Search settings" %}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title/heading matches the menu item name on admin subpages

Suggested change
{% trans "Search settings" %}
{% trans "Search" %}

active
{% endblock project_search_active %}
{% block project_edit_content_header %}
{% trans "Search settings" %}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{% trans "Search settings" %}
{% trans "Search" %}

@stsewd stsewd merged commit 53abeac into main Apr 13, 2026
7 checks passed
@stsewd stsewd deleted the show-search-settings branch April 13, 2026 21:07
stsewd added a commit to readthedocs/readthedocs.org that referenced this pull request Apr 13, 2026
I didn't include the option to disable search indexing here since its
from a separate model and it's only shown when we have disabled search
indexing, but isn't that complex to integrate if we wanted
11f16a1.

Closes #11533

Requires readthedocs/ext-theme#709

---------

Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: stsewd <4975310+stsewd@users.noreply.github.com>
Co-authored-by: Anthony <aj@ohess.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants