Tests: update automation rules test suite for v2 model by Copilot · Pull Request #12850 · readthedocs/readthedocs.org

Copilot · 2026-03-17T11:20:01Z

The automation rules v2 PR consolidated RegexAutomationRule, WebhookAutomationRule, and VersionAutomationRule into a single AutomationRule model. This PR updates the test suite to match.

`test_automation_rules.py`

Replace all RegexAutomationRule/WebhookAutomationRule/VersionAutomationRule references with AutomationRule
Field renames: match_arg → version_match_pattern, predefined_match_arg → version_predefined_match_pattern, version_type (str) → version_types (list)
Action constants: VersionAutomationRule.ACTIVATE_VERSION_ACTION → AutomationRule.ACTIVATE_VERSION_ACTION, etc.
Webhook rules now use webhook_files_match_pattern=[...] (JSONField list) instead of match_arg; test_version_type_filtering tests match_version() instead of run() since version type gating is no longer inside run()
Renamed TestRegexAutomationRules → TestAutomationRuleVersionMatching, test_add_rule_regex → test_add_rule

`test_automation_rule_views.py`

URL names: projects_automation_rule_regex_create/edit → projects_automation_rule_create/edit
POST data fields updated to match new AutomationRuleForm (version_predefined_match_pattern, version_types, version_match_pattern)
Drop test_empty_custom_match / test_invalid_regex (form no longer validates these); add test_create_rule_with_webhook_filter covering the new webhook filter field
test_create_rule_default_description now asserts rule.description is None and rule.get_description() == "Activate version" (description is no longer persisted, derived at runtime)

`test_githubapp_webhook.py`

Replace WebhookAutomationRule/VersionAutomationRule imports with AutomationRule from readthedocs.projects.models
Rule fixtures updated: match_arg → webhook_files_match_pattern=[...], version_type → version_types=[...], VersionAutomationRule.TRIGGER_BUILD_ACTION → AutomationRule.TRIGGER_BUILD_ACTION
Add version_predefined_match_pattern=ALL_VERSIONS to all webhook rule fixtures

# Before
rule = get(RegexAutomationRule, match_arg="^release-.*", version_type=TAG, ...)
# After
rule = get(AutomationRule, version_match_pattern="^release-.*", version_types=[TAG], ...)

💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.

Co-authored-by: humitos <244656+humitos@users.noreply.github.com>

humitos · 2026-04-09T12:03:23Z

@copilot can you update this PR with the latest changes in base branch and update the tests, please?

… copilot/sub-pr-12848 Co-authored-by: humitos <244656+humitos@users.noreply.github.com>

…edesign) Agent-Logs-Url: https://github.com/readthedocs/readthedocs.org/sessions/01f059aa-b9ab-4cad-a3e8-675ab67acff8 Co-authored-by: humitos <244656+humitos@users.noreply.github.com>

Copilot · 2026-04-09T12:58:52Z

@copilot can you update this PR with the latest changes in base branch and update the tests, please?

Done in commit 4d82d1b94. Merged the latest humitos/webhook-filters-v2 changes and updated both test files to reflect the new model structure:

AutomationRule is now imported from readthedocs.projects.models
Custom regex tests use version_predefined_match_pattern=CUSTOM_MATCH + version_match_pattern=<regex>
Webhook tests use the new separate webhook_files_match_pattern=[...] (JSONField list) instead of the old webhook_filter + webhook_match_pattern fields
View tests updated with CUSTOM_MATCH sentinel and webhook_files_match_pattern

read-the-docs-community · 2026-04-09T13:02:35Z

Documentation build overview

📚 dev | 🛠️ Build #32189469 | 📁 Comparing a42b6d6 against latest (50e8d78)

🔍 Preview build

Show files changed (2 files in total): 📝 2 modified | ➕ 0 added | ➖ 0 deleted

File	Status
aws-temporary-credentials.html	📝 modified
tests.html	📝 modified

Agent-Logs-Url: https://github.com/readthedocs/readthedocs.org/sessions/f555f801-41b7-4685-ab07-9f5d4bda99b4 Co-authored-by: humitos <244656+humitos@users.noreply.github.com>

humitos

Looks good to me

humitos · 2026-04-09T14:00:03Z

        if result:
            assert rule.run(version) is True


We are currently doing return True inside .run() but we probably should remove that because we call it manually only when it's needed now.

Noted — the callers in oauth/tasks.py don't use the return value from run(). Since that's a change to the model in the base branch (humitos/webhook-filters-v2), I'll leave it for that PR to decide whether to remove return True. The test line assert rule.run(version) is True here verifies the current behaviour; it can be dropped once return True is removed from the model.

Agent-Logs-Url: https://github.com/readthedocs/readthedocs.org/sessions/657866b4-c870-4ee0-a475-10018a6745fc Co-authored-by: humitos <244656+humitos@users.noreply.github.com>

Copilot · 2026-04-09T14:06:33Z

@copilot can you update this PR with the latest changes in base branch and update the tests, please?

Already up to date — the base branch (humitos/webhook-filters-v2) tip is at 12cd37e which was merged in commit e42bf01. No new changes to pull in.

humitos · 2026-04-09T14:53:12Z

@copilot the file readthedocs/oauth/tests/test_githubapp_webhook.py needs to be updated to use AutomationRule instead of WebhookAutomationRule or VersionAutomationRule. Note that we won't use those models anymore, so anything refering to those models should be updated.

…hookAutomationRule/VersionAutomationRule Agent-Logs-Url: https://github.com/readthedocs/readthedocs.org/sessions/61e9ef60-f3ce-4615-b389-4ba26c5b5e4a Co-authored-by: humitos <244656+humitos@users.noreply.github.com>

Copilot · 2026-04-09T15:11:42Z

@copilot the file readthedocs/oauth/tests/test_githubapp_webhook.py needs to be updated to use AutomationRule instead of WebhookAutomationRule or VersionAutomationRule. Note that we won't use ...

Done in commit 18bdf0b. Updated test_githubapp_webhook.py:

Import changed to from readthedocs.projects.models import AutomationRule (plus ALL_VERSIONS from readthedocs.builds.constants)
WebhookAutomationRule → AutomationRule in all 4 rule fixtures
VersionAutomationRule.TRIGGER_BUILD_ACTION → AutomationRule.TRIGGER_BUILD_ACTION
match_arg="docs/*.rst" → version_predefined_match_pattern=ALL_VERSIONS, webhook_files_match_pattern=["docs/*.rst"]
match_arg="docs/**" → version_predefined_match_pattern=ALL_VERSIONS, webhook_files_match_pattern=["docs/**"]
version_type=BRANCH/EXTERNAL → version_types=[BRANCH/EXTERNAL]
Updated all docstrings to remove WebhookAutomationRule references

Initial plan

4f88631

Copilot AI assigned Copilot and humitos Mar 17, 2026

Copilot AI mentioned this pull request Mar 17, 2026

Builds: automation rules v2 #12848

Open

Copilot started work on behalf of humitos March 17, 2026 11:20 View session

Update test cases to match automation rules v2 code changes

35920de

Co-authored-by: humitos <244656+humitos@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] [DOC-12788] Migrate automation rules to single model~~ Tests: update automation rules test suite for v2 model Mar 17, 2026

Copilot AI requested a review from humitos March 17, 2026 11:42

Copilot finished work on behalf of humitos March 17, 2026 11:42

Copilot started work on behalf of humitos April 9, 2026 12:03 View session

Copilot AI and others added 2 commits April 9, 2026 12:20

Merge remote-tracking branch 'origin/humitos/webhook-filters-v2' into…

e42bf01

… copilot/sub-pr-12848 Co-authored-by: humitos <244656+humitos@users.noreply.github.com>

Update tests to match latest base branch changes (AutomationRule v2 r…

4d82d1b

…edesign) Agent-Logs-Url: https://github.com/readthedocs/readthedocs.org/sessions/01f059aa-b9ab-4cad-a3e8-675ab67acff8 Co-authored-by: humitos <244656+humitos@users.noreply.github.com>

Copilot stopped work on behalf of humitos due to an error April 9, 2026 13:02
Failed to get response from the AI model; retried n times (total retry wait time: <duration>) Last error: Unknown error

humitos reviewed Apr 9, 2026

View reviewed changes

Comment thread readthedocs/rtd_tests/tests/test_automation_rules.py

Copilot started work on behalf of humitos April 9, 2026 13:58 View session

Restore missing test cases and comments in test_match_files parametrize

b8e2b73

Agent-Logs-Url: https://github.com/readthedocs/readthedocs.org/sessions/f555f801-41b7-4685-ab07-9f5d4bda99b4 Co-authored-by: humitos <244656+humitos@users.noreply.github.com>

humitos reviewed Apr 9, 2026

View reviewed changes

Copilot AI requested a review from humitos April 9, 2026 14:02

Copilot finished work on behalf of humitos April 9, 2026 14:02

Copilot started work on behalf of humitos April 9, 2026 14:02 View session

Restore removed comment in semver test parametrize

964b842

Agent-Logs-Url: https://github.com/readthedocs/readthedocs.org/sessions/657866b4-c870-4ee0-a475-10018a6745fc Co-authored-by: humitos <244656+humitos@users.noreply.github.com>

Copilot finished work on behalf of humitos April 9, 2026 15:01

Copilot started work on behalf of humitos April 9, 2026 15:08 View session

Copilot finished work on behalf of humitos April 9, 2026 15:16

humitos added 2 commits April 9, 2026 17:38

Don't use __contains on JSONField in SQLite because it's not supported

7fb7909

Update tests to pass

a42b6d6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Tests: update automation rules test suite for v2 model#12850

Tests: update automation rules test suite for v2 model#12850
Copilot wants to merge 9 commits intohumitos/webhook-filters-v2from
copilot/sub-pr-12848

Copilot AI commented Mar 17, 2026 •

edited

Loading

Uh oh!

humitos commented Apr 9, 2026

Uh oh!

Copilot AI commented Apr 9, 2026

Uh oh!

read-the-docs-community bot commented Apr 9, 2026 •

edited

Loading

Uh oh!

Uh oh!

humitos left a comment

Uh oh!

Uh oh!

humitos Apr 9, 2026

Uh oh!

Copilot AI Apr 9, 2026

Uh oh!

Copilot AI commented Apr 9, 2026

Uh oh!

humitos commented Apr 9, 2026

Uh oh!

Copilot AI commented Apr 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Copilot AI commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

test_automation_rules.py

test_automation_rule_views.py

test_githubapp_webhook.py

Uh oh!

humitos commented Apr 9, 2026

Uh oh!

Copilot AI commented Apr 9, 2026

Uh oh!

read-the-docs-community bot commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Documentation build overview

Uh oh!

Uh oh!

humitos left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

humitos Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Apr 9, 2026

Uh oh!

humitos commented Apr 9, 2026

Uh oh!

Copilot AI commented Apr 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Mar 17, 2026 •

edited

Loading

`test_automation_rules.py`

`test_automation_rule_views.py`

`test_githubapp_webhook.py`

read-the-docs-community bot commented Apr 9, 2026 •

edited

Loading