Remove pytest warnings #1515
Merged
Remove pytest warnings #1515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignore deprecations on Sphinx 9.0 that comes from readthedocs-sphinx-ext and use `findall()` instead of `.traverse()` as suggested by docutils.
agjohnson
approved these changes
Aug 29, 2023
Collaborator
|
Change looks reasonable, though tests are unhappy with the pytest ignore it seems: |
Collaborator
|
@humitos Care to update this with the test fixes? I think we're about ready to merge this with |
… humitos/remove-pytest-warnings
We are testing in older versions where this exception is not defined. The deprecation warning we are seeing here is not related to `sphinx_rtd_theme` but with `readthedocs-sphinx-ext` because at: https://github.com/rtfd/readthedocs-sphinx-ext/blob/13edf78bab374f51e314e4994c319fadbab806f2/readthedocs_ext/readthedocs.py#L118-L122 In any case, we will stop using that Sphinx extension at some point.
…cs/sphinx_rtd_theme into humitos/remove-pytest-warnings
Member
Author
|
I updated this PR and it's ready to be merged. The WARNING logs are related to our Sphinx extension because it access This will be removed in Sphinx 9.0. However, we should not keep using that extension sooner than later. So, I don't think there is anything else to do here. Changes on Sphinx: https://github.com/sphinx-doc/sphinx/blob/master/CHANGES.rst#deprecated-1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore deprecations on Sphinx 9.0 that comes from readthedocs-sphinx-ext and use
findall()instead of.traverse()as suggested by docutils.Closes #1142