Force cache creation to set default schema #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Force connection to set the default schema before attempting to create a cache. We use one single connection per host. During cache creation dry-run we enforce the default schema to be set, but During actual cache creation we do not. In case a client has more than one Readyset server, we will not execute the dry-run on the second server onwards. This will cause the cache creation to fail as the default schema is not set. This commit forces the default schema to be set before attempting to create a cache. Fixes: #31
altmannmarcelo
force-pushed
the
cache-creation-set-schema
branch
from
471e049 to
670e6ef
Compare
mvzink
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Force connection to set the default schema before attempting to create a cache. We use one single connection per host. During cache creation dry-run we enforce the default schema to be set, but During actual cache creation we do not. In case a client has more than one Readyset server, we will not execute the dry-run on the second server onwards. This will cause the cache creation to fail as the default schema is not set.
This commit forces the default schema to be set before attempting to create a cache.
Fixes: #31