Make the scheduler aware of the new readyset status #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davisjc
approved these changes
Feb 12, 2025
Contributor
davisjc
left a comment
davisjc
left a comment
There was a problem hiding this comment.
Looks good! I only have minor comments.
Readyset is adding a new status for maintanance mode, this will change the fields of SHOW READYSET STATUS command. This commit makes the scheduler aware of the new status.
altmannmarcelo
force-pushed
the
new_status
branch
from
ce8b64b to
38a8ce3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readyset is adding a new status for maintanance mode, this will change the fields of SHOW READYSET STATUS command. This commit makes the scheduler aware of the new status.