Misc cleanup #36
Closed
Misc cleanup #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
davisjc
commented
Mar 8, 2025
davisjc
commented
- Rename the struct Host -> Readyset to emphasize its specific nature and reflect the ProxySQL struct
- Similarly rename the module hosts -> readyset to emphasize its specific nature and reflect the proxysql module
- Rename ProxyStatus -> ProxySQLStatus to disambiguate the proxying we're talking about
- Remove some unused returns
- Use MIRROR_QUERY_TOKEN and DESTINATION_QUERY_TOKEN when possible instead of copy/paste
- Fix capitalization of Readyset/ProxySQL
- Fix conn typo
- Remove some trailing whitespace
- Remove some dead code
- Some minor comment changes
- Some minor README.md formatting changes
- Rename the struct Host -> Readyset to emphasize its specific nature and reflect the ProxySQL struct - Similarly rename the module hosts -> readyset to emphasize its specific nature and reflect the proxysql module - Rename ProxyStatus -> ProxySQLStatus to disambiguate the proxying we're talking about - Remove some unused returns - Use MIRROR_QUERY_TOKEN and DESTINATION_QUERY_TOKEN when possible instead of copy/paste - Fix capitalization of Readyset/ProxySQL - Fix conn typo - Remove some trailing whitespace - Remove some dead code - Some minor comment changes - Some minor README.md formatting changes
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.