Allow configuration for PostgreSQL #39
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds a new and optional configuration option, database_type, to the set of options available in the scheduler's config. Valid values are "mysql" and "postgresql", and if the option is omitted, "mysql" as treated as the default. Note that this patch does not yet introduce PostgreSQL support, but provides the initial restructuring of the scheduler. Abstract usage of an SQL connection into a new module, sql_connection, and a new enum representing a connection, SQLConnection, which represents either a MySQL or a PostgreSQL connection. Also replace all uses of mysql::Conn with the new SQLConnection enum, which acts as a thin wrapper.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a new and optional configuration option, database_type, to the set of options available in the scheduler's config. Valid values are "mysql" and "postgresql", and if the option is omitted, "mysql" as treated as the default.
Note that this patch does not yet introduce PostgreSQL support, but provides the initial restructuring of the scheduler.
Abstract usage of an SQL connection into a new module, sql_connection, and a new enum representing a connection, SQLConnection, which represents either a MySQL or a PostgreSQL connection. Also replace all uses of mysql::Conn with the new SQLConnection enum, which acts as a thin wrapper.