Skip to content

Fix prefer_self_in_static_references for value-type extensions - #6854

Draft
aryansk wants to merge 1 commit into
realm:mainfrom
aryansk:codex/swiftlint-prefer-self-extensions
Draft

Fix prefer_self_in_static_references for value-type extensions#6854
aryansk wants to merge 1 commit into
realm:mainfrom
aryansk:codex/swiftlint-prefer-self-extensions

Conversation

@aryansk

@aryansk aryansk commented Aug 2, 2026

Copy link
Copy Markdown

Summary

  • lint return types of static functions in extensions of same-file structs and enums
  • retain conservative behavior for class-like extensions
  • add triggering and non-triggering coverage plus a changelog entry

Fixes #6828

Validation

  • swift test --filter PreferSelfInStaticReferencesRuleGeneratedTests
  • swift test --filter IntegrationTests
  • swiftlint lint --strict --no-cache Source/SwiftLintBuiltInRules/Rules/Style/PreferSelfInStaticReferencesRule.swift Source/SwiftLintBuiltInRules/Rules/Style/PreferSelfInStaticReferencesRuleExamples.swift

@SwiftLintBot

Copy link
Copy Markdown
166 Warnings
⚠️ This PR may need tests.
⚠️ This PR introduced a violation in Alamofire: /Source/Core/HTTPHeaders.swift:217:51: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/HTTPHeaders.swift:225:58: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/HTTPHeaders.swift:237:59: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/HTTPHeaders.swift:249:59: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/HTTPHeaders.swift:260:77: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/HTTPHeaders.swift:271:62: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/HTTPHeaders.swift:284:58: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/HTTPHeaders.swift:293:63: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/HTTPHeaders.swift:302:60: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/HTTPHeaders.swift:314:56: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/HTTPHeaders.swift:323:54: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/HTTPHeaders.swift:331:62: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Alamofire: /Source/Features/ResponseSerialization.swift:422:40: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Sources/BrowserServicesKit/Watchdog/WatchdogDetectionState.swift:38:176: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in DuckDuckGo: /SharedPackages/AIChat/Sources/AIChat/Shared/NativeStorage/DuckAiChat.swift:95:65: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in DuckDuckGo: /SharedPackages/DebugServer/Sources/DebugServer/HTTPResponse.swift:43:69: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in DuckDuckGo: /SharedPackages/DebugServer/Sources/DebugServer/HTTPResponse.swift:52:73: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in DuckDuckGo: /SharedPackages/DebugServer/Sources/DebugServer/HTTPResponse.swift:61:73: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in DuckDuckGo: /SharedPackages/DebugServer/Sources/DebugServer/HTTPResponse.swift:70:63: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in DuckDuckGo: /SharedPackages/DataBrokerProtectionCore/Sources/DataBrokerProtectionCore/UIWeb/DBPUICommunicationModel.swift:365:85: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in DuckDuckGo: /SharedPackages/DataBrokerProtectionCore/Sources/DataBrokerProtectionCore/UIWeb/DBPUICommunicationModel.swift:510:51: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/TabBar/ViewModel/TabIndex.swift:102:64: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/TabBar/ViewModel/TabIndex.swift:111:63: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/TabBar/ViewModel/TabIndex.swift:120:78: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/TabBar/View/TabBackgroundView.swift:257:84: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/Feedback/Model/Feedback.swift:60:60: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/AIChat/AIChatSubscriptionUpsellDialog.swift:105:57: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/AIChat/AIChatSubscriptionUpsellDialog.swift:116:33: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/NavigationTests/Helpers/NavigationTestHelpers.swift:251:144: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/NavigationTests/Helpers/NavigationTestHelpers.swift:255:264: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/NavigationTests/Helpers/NavigationTestHelpers.swift:267:214: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/Subscription/Onboarding/Views/SubscriptionOnboardingInfoView.swift:126:75: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/Subscription/Onboarding/Views/SubscriptionOnboardingFreeTrialCalendarCard.swift:204:97: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/RichDuckAICells/DuckAIGridItem.swift:72:72: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Firefox: /firefox-ios/Client/Frontend/Browser/TopTabDisplayManager.swift:746:29: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Firefox: /firefox-ios/firefox-ios-tests/Tests/XCUITests/Selectors/SelectorHelper.swift:159:72: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Firefox: /firefox-ios/firefox-ios-tests/Tests/XCUITests/Selectors/SelectorHelper.swift:164:69: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Firefox: /firefox-ios/firefox-ios-tests/Tests/XCUITests/Selectors/SelectorHelper.swift:169:93: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Firefox: /firefox-ios/firefox-ios-tests/Tests/XCUITests/Selectors/SelectorHelper.swift:176:101: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Kickstarter: /Library/Sources/Library/Library/ViewModels/RewardCardViewModel.swift:396:46: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Kickstarter: /Library/Sources/Library/Library/RefInfo.swift:212:63: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Kickstarter: /Library/Sources/Library/Library/Navigation.swift:104:43: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Kickstarter: /Library/Sources/Library/Library/Navigation.swift:111:51: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Kickstarter: /Library/Sources/Library/Library/Navigation.swift:118:54: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/Sources/KsApi/models/Comment.swift:64:8: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/Sources/KsApi/models/PaymentIntentEnvelope.swift:26:8: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/Sources/KsApi/models/ValidateCheckoutEnvelope.swift:31:8: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/Sources/KsApi/models/CreateCheckoutEnvelope.swift:18:69: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/Sources/KsApi/models/ErrorEnvelope.swift:230:63: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in NetNewsWire: /Modules/CloudKitSync/Sources/CloudKitSync/CloudKitZoneResult.swift:67:68: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Realm: /RealmSwift/Realm.swift:1176:96: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Realm: /RealmSwift/Tests/TestValueFactory.swift:479:30: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Realm: /RealmSwift/Tests/TestValueFactory.swift:504:30: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Realm: /RealmSwift/Tests/TestValueFactory.swift:529:30: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Realm: /RealmSwift/Tests/TestValueFactory.swift:554:30: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Realm: /RealmSwift/Tests/TestValueFactory.swift:579:30: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Realm: /RealmSwift/Tests/TestValueFactory.swift:604:30: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Realm: /RealmSwift/Tests/TestValueFactory.swift:629:30: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Realm: /RealmSwift/Tests/TestValueFactory.swift:654:30: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Sourcery: /SourceryFramework/Sources/Parsing/Utils/StringView.swift:45:62: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Sourcery: /SourceryFramework/Sources/Parsing/Utils/StringView.swift:53:62: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/UnsafeRawPointer.swift:881:8: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/SIMDVector.swift:747:84: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/SIMDVector.swift:756:34: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/SIMDVector.swift:982:48: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/SIMDVector.swift:999:54: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/SIMDVector.swift:1013:54: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/SIMDVector.swift:1030:54: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/SIMDVector.swift:1443:50: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/SIMDVector.swift:1451:50: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/SIMDVector.swift:1459:50: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/SIMDVector.swift:1467:50: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/SIMDVector.swift:1475:50: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/SIMDVector.swift:1483:50: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Array.swift:969:9: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Array.swift:988:9: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Array.swift:1463:52: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Array.swift:2179:8: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/ArraySlice.swift:763:9: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Mirror.swift:319:49: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Mirror.swift:325:14: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/String.swift:424:29: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/String.swift:995:54: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Bool.swift:183:51: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Bool.swift:239:44: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Bool.swift:280:10: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Bool.swift:320:10: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/ContiguousArray.swift:625:9: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Duration.swift:134:65: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Duration.swift:166:52: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Duration.swift:180:8: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Duration.swift:195:62: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Duration.swift:209:8: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Duration.swift:224:62: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Duration.swift:238:8: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Duration.swift:253:60: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Duration.swift:307:62: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Duration.swift:312:62: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Duration.swift:330:60: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Duration.swift:342:8: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Duration.swift:357:60: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Duration.swift:364:8: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Synchronization/Atomics/WordPair.swift:133:8: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Synchronization/Atomics/AtomicMemoryOrderings.swift:344:8: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Codable.swift:3900:8: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Codable.swift:3921:8: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Codable.swift:3943:8: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Swift: /stdlib/public/RuntimeModule/Backtrace.swift:469:15: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Wire: /wire-ios/Wire-iOS/Sources/UserInterface/StartUI/StartUI/SearchResultsViewController.swift:46:67: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Wire: /wire-ios/Wire-iOS/Sources/UserInterface/StartUI/StartUI/SearchResultsViewController.swift:48:67: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Wire: /wire-ios-request-strategy/Sources/Calling/AVSIdentifier.swift:56:10: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Wire: /WireMessaging/Sources/WireMessagingUI/WireDrive/Components/Files/Previewers/QuickPreviewItem.swift:41:63: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Wire: /WireMessaging/Sources/WireMessagingUI/WireDrive/Components/Files/Previewers/QuickPreviewItem.swift:65:71: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Wire: /WireMessaging/Sources/WireMessagingUI/WireDrive/Components/Files/Item/FilesViewItem.swift:85:52: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Wire: /WireMessaging/Sources/WireMessagingUI/WireDrive/Components/Files/Item/FilesViewItem.swift:124:10: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Wire: /wire-ios-data-model/Source/Model/QualifiedID.swift:134:33: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Wire: /wire-ios-data-model/Source/Model/Conversation/ZMConversation+AccessMode.swift:74:60: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Wire: /wire-ios-data-model/Source/Model/Conversation/ZMConversation+AccessMode.swift:162:60: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Wire: /wire-ios-system/Source/SanitizedString.swift:49:95: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in Wire: /wire-ios-sync-engine/Source/Registration/Company/CompanyLoginVerificationToken.swift:63:67: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/Navigation/ReaderNavigationPath.swift:21:52: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in WordPress: /WordPress/Classes/ViewRelated/Domains/View Models/DomainsStateViewModel.swift:15:91: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in WordPress: /WordPress/Classes/ViewRelated/Post/PostSettings/PostSettingsCapabilities.swift:23:27: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in WordPress: /WordPress/Classes/ViewRelated/Post/PostSettings/PostSettingsCapabilities.swift:45:27: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in WordPress: /WordPress/Classes/ViewRelated/Blog/Blog Details/BlogDetailsTableViewModel.swift:1017:69: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in WordPress: /WordPress/Classes/ViewRelated/Blog/Blog Details/BlogDetailsTableViewModel.swift:1029:70: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in WordPress: /WordPress/Classes/ViewRelated/Blog/Blog Details/BlogDetailsTableViewModel.swift:1044:70: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in WordPress: /WordPress/Classes/ViewRelated/Blog/Blog Details/BlogDetailsTableViewModel.swift:1059:80: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in WordPress: /WordPress/Classes/ViewRelated/Blog/Blog Details/BlogDetailsTableViewModel.swift:1070:103: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in WordPress: /WordPress/Classes/ViewRelated/Blog/Blog Details/BlogDetailsTableViewModel.swift:1081:70: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in WordPress: /WordPress/Classes/ViewRelated/Blog/Blog Details/BlogDetailsTableViewModel.swift:1094:73: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ This PR introduced a violation in WordPress: /WordPress/Classes/ViewRelated/Blog/Blog Details/BlogDetailsTableViewModel.swift:1108:75: Warning: Use Self to refer to the surrounding type name (prefer_self_in_static_references)
⚠️ Danger found 166 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 133.
19 Messages
📖 Building this branch resulted in a binary size of 28428.4 KiB vs 28425.27 KiB when built on main (0% larger).
📖 Linting Aerial with this PR took 0.65 s vs 0.65 s on main (0% slower).
📖 Linting Alamofire with this PR took 0.94 s vs 0.91 s on main (3% slower).
📖 Linting Brave with this PR took 6.02 s vs 6.03 s on main (0% faster).
📖 Linting DuckDuckGo with this PR took 27.51 s vs 27.25 s on main (0% slower).
📖 Linting Firefox with this PR took 10.7 s vs 10.67 s on main (0% slower).
📖 Linting Kickstarter with this PR took 7.07 s vs 7.31 s on main (3% faster).
📖 Linting Moya with this PR took 0.37 s vs 0.38 s on main (2% faster).
📖 Linting NetNewsWire with this PR took 2.35 s vs 2.33 s on main (0% slower).
📖 Linting Nimble with this PR took 0.56 s vs 0.55 s on main (1% slower).
📖 Linting PocketCasts with this PR took 6.95 s vs 6.91 s on main (0% slower).
📖 Linting Quick with this PR took 0.36 s vs 0.35 s on main (2% slower).
📖 Linting Realm with this PR took 2.82 s vs 2.85 s on main (1% faster).
📖 Linting Sourcery with this PR took 1.57 s vs 1.67 s on main (5% faster).
📖 Linting Swift with this PR took 4.26 s vs 4.24 s on main (0% slower).
📖 Linting SwiftLintPerformanceTests with this PR took 0.16 s vs 0.16 s on main (0% slower).
📖 Linting VLC with this PR took 1.26 s vs 1.25 s on main (0% slower).
📖 Linting Wire with this PR took 15.51 s vs 15.45 s on main (0% slower).
📖 Linting WordPress with this PR took 9.72 s vs 9.72 s on main (0% slower).

Generated by 🚫 Danger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

prefer_self_in_static_references doesn't report violations in extensions

2 participants