Add shared list formatting infrastructure for CLI commands - #2
Closed
realrajaryan wants to merge 1 commit into
Closed
Add shared list formatting infrastructure for CLI commands#2realrajaryan wants to merge 1 commit into
realrajaryan wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR consolidates the duplicated list formatting logic across all CLI list commands into shared infrastructure.
Every list command independently implemented the same if-json/if-quiet/else-table rendering pattern. This extracts that into a ListDisplayable protocol (table contract), printList() (table/quiet rendering), and printJSON() (all JSON encoding across the module).
JSON encoding is deliberately separated from the display protocol -- each command encodes its own raw data model for JSON, while display types only handle table/quiet. Each command keeps its own --format and --quiet flags with domain-specific help text rather than a generic option group.
Also moves TableOutput to ContainerCommands, deletes Codable+JSON.swift, migrates all remaining inline JSONEncoder usage to printJSON, and adds unit tests for the formatting infrastructure.