add summary

Author: Nir-Az

.github/workflows/clang-tidy.yml

@@ -12,13 +12,12 @@ jobs:
 
     steps:
       - name: Checkout repository
-        uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 #v4
+        uses: actions/checkout@v4
 
       - name: Install clang tidy dependencies
         run: |
           sudo apt update
           sudo apt install -y clang clang-tidy cmake g++ ninja-build
-
       - name: Install SDK dependencies
         run: |
           sudo apt update
@@ -27,7 +26,6 @@ jobs:
           sudo apt-get install -qq libgtk-3-dev;
           sudo apt-get install libglfw3-dev libglfw3;
 
-
       - name: Configure project with CMake
         run: |
           cmake -S . -B build \
@@ -39,7 +37,6 @@ jobs:
       - name: Build project
         run: cmake --build build -j$(nproc)
 
-      # 👇 This stage writes the .clang-tidy file
       - name: Create .clang-tidy config
         run: |
           cat <<'EOF' > .clang-tidy
@@ -53,9 +50,10 @@ jobs:
             modernize-use-nullptr,
             modernize-use-override,
             modernize-use-auto,
-            misc-unused-parameters
-          WarningsAsErrors: '*'
-          HeaderFilterRegex: 'src/.*'
+            misc-unused-parameters,
+            misc-strcmp
+          # WarningsAsErrors: '*'   # <-- Commented out to not fail on all warnings
+          HeaderFilterRegex: 'src/(?!third-party).*' # consider adding some third party that are not actually third party like realdds
           FormatStyle: none
           CheckOptions:
             - key: readability-implicit-bool-conversion.AllowIntegerConditions
@@ -67,9 +65,41 @@ jobs:
           echo "Running clang-tidy..."
           cp build/compile_commands.json .
           clang-tidy -p . $(find src -name '*.cpp') 2>&1 | tee clang-tidy.log
-          if grep -E "warning:|error:" clang-tidy.log; then
-            echo "❌ Clang-Tidy found issues."
+
+      # === NEW: Extract errors only to a separate log ===
+      - name: Extract errors from clang-tidy log
+        run: |
+          awk '/error:/ && !/\[clang-diagnostic-error\]/' clang-tidy.log > clang-tidy-errors.log
+
+      # === NEW: Summarize only errors at the end ===
+      - name: Errors Only Summary
+        run: |
+          echo "Clang-Tidy Errors Only Summary:"
+          total_errors=$(cat clang-tidy-errors.log | wc -l)
+          echo ""
+          echo "Total errors found: $total_errors"
+          echo ""
+          if (( total_errors > 0 )); then
+            echo "Top error types:"
+            grep -oE '\[[^][]+\]' clang-tidy-errors.log | sort | uniq -c | sort -nr | head -20
+            echo ""
+            echo "CI failed due to errors. See clang-tidy-errors.log for details."
             exit 1
           else
-            echo "✅ Clang-Tidy passed cleanly."
+            echo "✅ No clang-tidy errors found."
           fi
+
+      - name: Upload full clang-tidy log as Artifact
+        if: always()
+        uses: actions/upload-artifact@v4
+        with:
+          name: clang-tidy-log
+          path: clang-tidy.log
+
+      # === NEW: Upload errors-only log as artifact ===
+      - name: Upload clang-tidy errors-only log as Artifact
+        if: always()
+        uses: actions/upload-artifact@v4
+        with:
+          name: clang-tidy-errors-log
+          path: clang-tidy-errors.log