textual icons to string corrections

Author: remibettan

common/output-model.cpp

@@ -583,7 +583,10 @@ void output_model::draw(ux_window& win, rect view_rect, device_models_list & dev
 
 
         ImGui::SetCursorPos(ImVec2(7, h - ImGui::GetTextLineHeightWithSpacing() - 2));
-        ImGui::Text("%s", textual_icons::minus_square_o); ImGui::SameLine();
+        std::string minus_square_icon_str = std::string(rsutils::string::from()
+                            << textual_icons::minus_square_o);
+        ImGui::Text("%s", minus_square_icon_str.c_str());
+        ImGui::SameLine();
         ImGui::SetCursorPos(ImVec2(30, h - ImGui::GetTextLineHeightWithSpacing() - 4));
 
 

common/viewer.cpp

@@ -2716,7 +2716,7 @@ namespace rs2
                         std::string excl_icon_str = std::string(rsutils::string::from()
                             << textual_icons::exclamation_triangle
                             << " Using GLSL for processing but not for rendering can reduce CPU utilisation, but is likely to hurt overall performance!");
-                        ImGui::Text(excl_icon_str.c_str());
+                        ImGui::Text("%s", excl_icon_str.c_str());
                         ImGui::PopStyleColor();
                     }
 #endif
@@ -2974,7 +2974,7 @@ namespace rs2
                     std::string excl_icon_str = std::string(rsutils::string::from() 
                         << textual_icons::exclamation_triangle 
                         << " DDS changes will take effect only after restarting the application");
-                    ImGui::Text(excl_icon_str.c_str());
+                    ImGui::Text("%s", excl_icon_str.c_str());
                     ImGui::PopStyleColor();
 
                 }
@@ -3052,7 +3052,7 @@ namespace rs2
                     std::string excl_icon_str = std::string(rsutils::string::from()
                         << textual_icons::exclamation_triangle
                         << " The application will be restarted in order for new settings to take effect");
-                    ImGui::Text(excl_icon_str.c_str());
+                    ImGui::Text("%s", excl_icon_str.c_str());
                     ImGui::PopStyleColor();
                 }