try copilot way

Author: Nir-Az

.github/workflows/clang-tidy.yml

@@ -17,7 +17,7 @@ jobs:
       - name: Install clang tidy dependencies
         run: |
           sudo apt update
-          sudo apt install -y clang clang-tidy cmake g++ ninja-build
+          sudo apt install -y clang clang-tidy cmake g++ ninja-build jq
       - name: Install SDK dependencies
         run: |
           sudo apt update
@@ -30,8 +30,11 @@ jobs:
         run: |
           cmake -S . -B build \
             -DCMAKE_CXX_COMPILER=clang++ \
+            -DCMAKE_C_COMPILER=clang \
             -DCMAKE_EXPORT_COMPILE_COMMANDS=ON \
             -DCHECK_FOR_UPDATES=OFF \
+            -DBUILD_EXAMPLES=ON \
+            -DBUILD_TOOLS=ON \
             -DCMAKE_BUILD_TYPE=Release
 
       - name: Build project
@@ -42,35 +45,127 @@ jobs:
           cat <<'EOF' > .clang-tidy
           Checks: >
             -*,
-            readability-string-compare,
+            bugprone-string-compare,
             bugprone-suspicious-string-compare,
-            bugprone-*,
+            bugprone-string-literal-with-embedded-nul,
+            bugprone-compare-pointer-to-member-virtual-function,
+            bugprone-signed-char-misuse,
+            bugprone-bool-pointer-implicit-conversion,
+            bugprone-argument-comment,
+            bugprone-assert-side-effect,
+            bugprone-branch-clone,
+            bugprone-copy-constructor-init,
+            bugprone-dangling-handle,
+            bugprone-exception-escape,
+            bugprone-fold-init-type,
+            bugprone-forward-declaration-namespace,
+            bugprone-forwarding-reference-overload,
+            bugprone-inaccurate-erase,
+            bugprone-incorrect-roundings,
+            bugprone-infinite-loop,
+            bugprone-integer-division,
+            bugprone-lambda-function-name,
+            bugprone-macro-parentheses,
+            bugprone-macro-repeated-side-effects,
+            bugprone-misplaced-operator-in-strlen-in-alloc,
+            bugprone-misplaced-pointer-arithmetic-in-alloc,
+            bugprone-misplaced-widening-cast,
+            bugprone-move-forwarding-reference,
+            bugprone-multiple-statement-macro,
+            bugprone-parent-virtual-call,
+            bugprone-posix-return,
+            bugprone-sizeof-container,
+            bugprone-sizeof-expression,
+            bugprone-string-constructor,
+            bugprone-string-integer-assignment,
+            bugprone-suspicious-enum-usage,
+            bugprone-suspicious-memset-usage,
+            bugprone-suspicious-missing-comma,
+            bugprone-suspicious-semicolon,
+            bugprone-swapped-arguments,
+            bugprone-terminating-continue,
+            bugprone-throw-keyword-missing,
+            bugprone-too-small-loop-variable,
+            bugprone-undefined-memory-manipulation,
+            bugprone-undelegated-constructor,
+            bugprone-unhandled-self-assignment,
+            bugprone-unused-raii,
+            bugprone-unused-return-value,
+            bugprone-use-after-move,
+            bugprone-virtual-near-miss,
+            cert-dcl21-cpp,
+            cert-dcl58-cpp,
+            cert-err34-c,
+            cert-err52-cpp,
+            cert-err60-cpp,
+            cert-flp30-c,
+            cert-msc50-cpp,
+            cert-msc51-cpp,
+            cert-oop58-cpp,
+            readability-string-compare,
             readability-implicit-bool-conversion,
-            performance-inefficient-string-concatenation,
             modernize-use-nullptr,
-            modernize-use-override,
-            modernize-use-auto,
-            misc-unused-parameters,
-            misc-strcmp
-          # WarningsAsErrors: '*'   # <-- Commented out to not fail on all warnings
-          #HeaderFilterRegex: 'src/(?!third-party).*' # consider adding some third party that are not actually third party like realdds
+            performance-inefficient-string-concatenation
+          WarningsAsErrors: ''
+          HeaderFilterRegex: '(src|include|common|tools|examples)/.*\.(h|hpp)$'
           FormatStyle: none
           CheckOptions:
             - key: readability-implicit-bool-conversion.AllowIntegerConditions
               value: 'false'
+            - key: readability-implicit-bool-conversion.AllowPointerConditions
+              value: 'false'
           EOF
+          echo "Created .clang-tidy configuration:"
+          cat .clang-tidy
 
       - name: Run clang-tidy
         run: |
           echo "Running clang-tidy..."
           cp build/compile_commands.json .
-          #clang-tidy -p . $(find src -name '*.cpp') 2>&1 | tee clang-tidy.log
-          clang-tidy -p . $(find common examples tools wrappers/python src third-party/rsutils third-party/realdds -name '*.cpp')  2>&1 | tee clang-tidy.log
+          # Run clang-tidy only on files that are in compile_commands.json
+          # This avoids "Error while processing" for files not in the build
+          echo "Files in compile database:"
+          jq -r '.[].file' compile_commands.json | head -20
+          
+          # Find only .cpp files that exist in compile_commands.json
+          # Exclude third-party files except realdds and rsutils
+          FILES_TO_CHECK=$(jq -r '.[].file' compile_commands.json | \
+            grep -E '\.(cpp|cc|cxx)$' | \
+            grep -v 'third-party/' | \
+            sort -u)
+          
+          # Add back third-party/realdds and third-party/rsutils
+          FILES_TO_CHECK_THIRD_PARTY=$(jq -r '.[].file' compile_commands.json | \
+            grep -E '\.(cpp|cc|cxx)$' | \
+            grep -E 'third-party/(realdds|rsutils)/' | \
+            sort -u)
+          
+          FILES_TO_CHECK=$(echo -e "$FILES_TO_CHECK\n$FILES_TO_CHECK_THIRD_PARTY" | grep -v '^$' | sort -u)
+          
+          if [ -z "$FILES_TO_CHECK" ]; then
+            echo "No files found in compile_commands.json"
+            exit 1
+          fi
+          
+          echo "Running clang-tidy on $(echo "$FILES_TO_CHECK" | wc -l) files..."
+          echo "Sample files to check:"
+          echo "$FILES_TO_CHECK" | head -10
+          echo "$FILES_TO_CHECK" | xargs clang-tidy -p . 2>&1 | tee clang-tidy.log
+          
+          # Show summary of issues found
+          echo ""
+          echo "=== Summary of issues found ==="
+          grep -E 'warning:|error:' clang-tidy.log | grep -v '\[clang-diagnostic' | wc -l || echo "0 issues found"
 
       # === NEW: Extract errors only to a separate log ===
       - name: Extract errors from clang-tidy log
         run: |
-          awk '/error:/ && !/\[clang-diagnostic-error\]/' clang-tidy.log > clang-tidy-errors.log
+          # Extract actual clang-tidy warnings/errors, excluding:
+          # - clang-diagnostic-* (compilation errors)
+          # - "Error while processing" messages
+          grep -E 'warning:|error:' clang-tidy.log | \
+            grep -v '\[clang-diagnostic' | \
+            grep -v 'Error while processing' > clang-tidy-errors.log || true
 
       # === NEW: Summarize only errors at the end ===
       - name: Errors Only Summary