PR #14427 from remibettan: Fix string pedantic issues

Author: Nir-Az

common/output-model.cpp

@@ -583,7 +583,10 @@ void output_model::draw(ux_window& win, rect view_rect, device_models_list & dev
 
 
         ImGui::SetCursorPos(ImVec2(7, h - ImGui::GetTextLineHeightWithSpacing() - 2));
-        ImGui::Text("%s", textual_icons::minus_square_o); ImGui::SameLine();
+        std::string minus_square_icon_str = std::string(rsutils::string::from()
+                            << textual_icons::minus_square_o);
+        ImGui::Text("%s", minus_square_icon_str.c_str());
+        ImGui::SameLine();
         ImGui::SetCursorPos(ImVec2(30, h - ImGui::GetTextLineHeightWithSpacing() - 4));
 
 

common/viewer.cpp

@@ -2716,7 +2716,7 @@ namespace rs2
                         std::string excl_icon_str = std::string(rsutils::string::from()
                             << textual_icons::exclamation_triangle
                             << " Using GLSL for processing but not for rendering can reduce CPU utilisation, but is likely to hurt overall performance!");
-                        ImGui::Text(excl_icon_str.c_str());
+                        ImGui::Text("%s", excl_icon_str.c_str());
                         ImGui::PopStyleColor();
                     }
 #endif
@@ -2974,7 +2974,7 @@ namespace rs2
                     std::string excl_icon_str = std::string(rsutils::string::from() 
                         << textual_icons::exclamation_triangle 
                         << " DDS changes will take effect only after restarting the application");
-                    ImGui::Text(excl_icon_str.c_str());
+                    ImGui::Text("%s", excl_icon_str.c_str());
                     ImGui::PopStyleColor();
 
                 }
@@ -3052,7 +3052,7 @@ namespace rs2
                     std::string excl_icon_str = std::string(rsutils::string::from()
                         << textual_icons::exclamation_triangle
                         << " The application will be restarted in order for new settings to take effect");
-                    ImGui::Text(excl_icon_str.c_str());
+                    ImGui::Text("%s", excl_icon_str.c_str());
                     ImGui::PopStyleColor();
                 }
 

tools/depth-quality/depth-quality-model.cpp

@@ -430,7 +430,9 @@ namespace rs2
                                     ImGui::SetCursorPos({ pos.x + 57, pos.y + bar_spacing * (i - j) + 14 });
                                     ImGui::PushStyleColor(ImGuiCol_Text,
                                         blend(blend(light_grey, alpha), distance_guide ? 1.f : fade_factor));
-                                    ImGui::Text(textual_icons::angle_right);
+                                    std::string angle_right_str = std::string(rsutils::string::from()
+                            << textual_icons::angle_right);
+                                    ImGui::Text("%s", angle_right_str.c_str());
                                     ImGui::PopStyleColor();
                                 }
                             }
@@ -445,7 +447,8 @@ namespace rs2
                                     ImGui::SetCursorPos({ pos.x + 57, pos.y + bar_spacing * (i + j) + 14 });
                                     ImGui::PushStyleColor(ImGuiCol_Text,
                                         blend(blend(light_grey, alpha), distance_guide ? 1.f : fade_factor));
-                                    ImGui::Text(textual_icons::angle_left);
+                                    std::string angle_left_str = std::string(rsutils::string::from() << textual_icons::angle_left);
+                                    ImGui::Text("%s", angle_left_str.c_str());
                                     ImGui::PopStyleColor();
                                 }
                             }
@@ -1240,7 +1243,9 @@ namespace rs2
                 auto col0 = ImGui::GetCursorPos();
                 ImGui::SetCursorPosX(left_x);
                 ImGui::PushFont(win.get_large_font());
-                ImGui::Text(textual_icons::angle_double_up);
+                std::string angle_double_up_str = std::string(rsutils::string::from()
+                            << textual_icons::angle_double_up);
+                ImGui::Text("%s", angle_double_up_str.c_str());
                 if (ImGui::IsItemHovered())
                 {
                     RsImGui::CustomTooltip("This metric shows positive trend");
@@ -1256,7 +1261,9 @@ namespace rs2
                 auto col0 = ImGui::GetCursorPos();
                 ImGui::SetCursorPosX(left_x);
                 ImGui::PushFont(win.get_large_font());
-                ImGui::Text(textual_icons::angle_double_down);
+                std::string angle_double_down_str = std::string(rsutils::string::from()
+                            << textual_icons::angle_double_down);
+                ImGui::Text("%s", angle_double_down_str.c_str());
                 if (ImGui::IsItemHovered())
                 {
                     RsImGui::CustomTooltip("This metric shows negative trend");