inject error

Author: Nir-Az

.github/workflows/clang-tidy.yml

@@ -31,11 +31,14 @@ jobs:
           cmake -S . -B build \
             -DCMAKE_CXX_COMPILER=clang++ \
             -DCMAKE_C_COMPILER=clang \
+            -DCMAKE_CXX_FLAGS="-Waddress" \
+            -DCMAKE_C_FLAGS="-Waddress" \
             -DCMAKE_EXPORT_COMPILE_COMMANDS=ON \
             -DCHECK_FOR_UPDATES=OFF \
             -DBUILD_EXAMPLES=ON \
             -DBUILD_TOOLS=ON \
-            -DCMAKE_BUILD_TYPE=Release
+            -DENABLE_SECURITY_FLAGS=ON \ 
+            -DCMAKE_BUILD_TYPE=Debug
 
       - name: Build project
         run: cmake --build build -j$(nproc)
@@ -47,10 +50,6 @@ jobs:
             -*,
             bugprone-string-compare,
             bugprone-suspicious-string-compare,
-            bugprone-string-literal-with-embedded-nul,
-            bugprone-compare-pointer-to-member-virtual-function,
-            bugprone-signed-char-misuse,
-            bugprone-bool-pointer-implicit-conversion,
             bugprone-argument-comment,
             bugprone-assert-side-effect,
             bugprone-branch-clone,
@@ -102,7 +101,7 @@ jobs:
             cert-msc50-cpp,
             cert-msc51-cpp,
             cert-oop58-cpp,
-            readability-string-compare,
+            clang-diagnostic-address,
             readability-implicit-bool-conversion,
             modernize-use-nullptr,
             performance-inefficient-string-concatenation
@@ -114,6 +113,8 @@ jobs:
               value: 'false'
             - key: readability-implicit-bool-conversion.AllowPointerConditions
               value: 'false'
+            - key: clang-diagnostic-address
+              value: 'true'
           EOF
           echo "Created .clang-tidy configuration:"
           cat .clang-tidy
@@ -160,10 +161,11 @@ jobs:
       # === NEW: Extract errors only to a separate log ===
       - name: Extract errors from clang-tidy log
         run: |
-          # Extract actual clang-tidy errors, excluding:
+          # Extract actual clang-tidy warnings/errors, excluding:
           # - clang-diagnostic-* (compilation errors)
           # - "Error while processing" messages
-          grep -E 'error:' clang-tidy.log | \
+          # Match format: /path/to/file.cpp:123:45: error: message [check-name]
+          grep -E '^[^:]+:[0-9]+:[0-9]+: (error):' clang-tidy.log | \
             grep -v '\[clang-diagnostic' | \
             grep -v 'Error while processing' > clang-tidy-errors.log || true
 

src/ds/d400/d400-auto-calibration.cpp

@@ -271,9 +271,13 @@ namespace librealsense
             case ds_calib_common::SPEED_WHITE_WALL:
                 _total_frames = 120;
                 /* Inject string comparation issue by purpose to see if clang tidy finds it - REMOVE!!*/
-                char * tmp = "NIR";
-                if (tmp == "NIR") 
-                    int a = 0;
+                {
+                    const char * tmp = "NIR";
+                    if (tmp == "NIR") {
+                        int a = 0;
+                        a++;  // Use the variable
+                    }
+                }
                 break;
             }
             std::fill_n(_fill_factor, 256, 0);

tools/dds/dds-adapter/CMakeLists.txt

@@ -1,6 +1,6 @@
 # License: Apache 2.0. See LICENSE file in root directory.
 # Copyright(c) 2023-2024 RealSense, Inc. All Rights Reserved.
-cmake_minimum_required( VERSION 3.8 )
+cmake_minimum_required( VERSION 3.10 )
 project( rs-dds-adapter )
 
 set(TOOL_FILES