inject error

Author: Nir-Az

.github/workflows/clang-tidy.yml

@@ -35,7 +35,7 @@ jobs:
             -DCHECK_FOR_UPDATES=OFF \
             -DBUILD_EXAMPLES=ON \
             -DBUILD_TOOLS=ON \
-            -DCMAKE_BUILD_TYPE=Release
+            -DCMAKE_BUILD_TYPE=Debug
 
       - name: Build project
         run: cmake --build build -j$(nproc)
@@ -160,10 +160,11 @@ jobs:
       # === NEW: Extract errors only to a separate log ===
       - name: Extract errors from clang-tidy log
         run: |
-          # Extract actual clang-tidy errors, excluding:
+          # Extract actual clang-tidy warnings/errors, excluding:
           # - clang-diagnostic-* (compilation errors)
           # - "Error while processing" messages
-          grep -E 'error:' clang-tidy.log | \
+          # Match format: /path/to/file.cpp:123:45: error: message [check-name]
+          grep -E '^[^:]+:[0-9]+:[0-9]+: (error):' clang-tidy.log | \
             grep -v '\[clang-diagnostic' | \
             grep -v 'Error while processing' > clang-tidy-errors.log || true
 

src/ds/d400/d400-auto-calibration.cpp

@@ -271,9 +271,13 @@ namespace librealsense
             case ds_calib_common::SPEED_WHITE_WALL:
                 _total_frames = 120;
                 /* Inject string comparation issue by purpose to see if clang tidy finds it - REMOVE!!*/
-                char * tmp = "NIR";
-                if (tmp == "NIR") 
-                    int a = 0;
+                {
+                    const char * tmp = "NIR";
+                    if (tmp == "NIR") {
+                        int a = 0;
+                        a++;  // Use the variable
+                    }
+                }
                 break;
             }
             std::fill_n(_fill_factor, 256, 0);

tools/dds/dds-adapter/CMakeLists.txt

@@ -1,6 +1,6 @@
 # License: Apache 2.0. See LICENSE file in root directory.
 # Copyright(c) 2023-2024 RealSense, Inc. All Rights Reserved.
-cmake_minimum_required( VERSION 3.8 )
+cmake_minimum_required( VERSION 3.10 )
 project( rs-dds-adapter )
 
 set(TOOL_FILES