[PATCH] Fix Y12I streaming error handling in vi5_capture_dequeue - #338
Merged
Conversation
ymodlin
force-pushed
the
FIX_20980_RGB_green_bar
branch
from
January 22, 2026 07:17
495a907 to
09e0076
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| + /* TODO: Remove the branch or process the error for Y12I only */ | ||
| + if (false && frame_err) | ||
| + /* TODO: Remove once Y12I streaming fixed */ | ||
| + if (frame_err && chan->fmtinfo->fourcc != V4L2_PIX_FMT_Y12I) |
There was a problem hiding this comment.
The condition excludes Y12I from error handling, meaning frames with errors will be marked as DONE instead of ERROR for Y12I format. This could mask real frame errors and lead to corrupted data being processed downstream. If Y12I genuinely produces false positive frame errors, document the specific error conditions being suppressed and consider filtering only those specific errors rather than all frame errors.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
ymodlin
previously approved these changes
Jan 22, 2026
ymodlin
approved these changes
Jan 22, 2026
ymodlin
pushed a commit
that referenced
this pull request
Jan 22, 2026
Bump driver version to 1.0.1.33 (#339)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve error handling for Y12I streaming by refining the condition that sets the buffer state to error. This change addresses the specific handling of frame errors for Y12I format.