Add D401 GMSL support and align resolutions - #342
Conversation
- Added res 1288x808 for calibration - Aligned other Y resolutions - Bumped version to 1.0.2.1 Signed-off-by: ejgoldik <ehud.joseph.goldik@realsenseai.com>
There was a problem hiding this comment.
Pull request overview
This PR introduces initial support for the D401 GMSL camera variant by adding device type definitions, resolution configurations, and format specifications that align with the D401 USB variant. The module version is updated to 1.0.2.3.
Changes:
- Added D401 GMSL device type constant and associated resolution/format configurations
- Integrated D401 GMSL into the fixed configuration logic for depth, IR, and RGB sensors
- Updated module version from 1.0.1.33 to 1.0.2.4
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
D40x and D45x have the same RGB formats for now Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
ejgoldik
left a comment
ejgoldik
left a comment
There was a problem hiding this comment.
Last commit creates kernel panic and should be reverted
Reverted setting sensor->formats = NULL; This caused kernel panic (null pointer reference) Signed-off-by: ejgoldik <ehud.joseph.goldik@realsenseai.com>
ymodlin
left a comment
ymodlin
left a comment
There was a problem hiding this comment.
Only d4xx changes? for the calibration format there is no change in the OOT?
Signed-off-by: ejgoldik <ehud.joseph.goldik@realsenseai.com>
[INFRA] Update kernel deployment scripts to support JP5.0.2 and update apply_patches.sh to simplify patch creation process
ejgoldik
left a comment
ejgoldik
left a comment
There was a problem hiding this comment.
In apply_patches.sh -
Staging the modified files causes build errors after the next "apply_patches reset". Need to fix or revert this
![aikido-pr-checks[bot]](https://avatars.githubusercontent.com/in/898896?s=60&v=4){kind=small}
| fi | ||
|
|
||
| echo "Copying kernel files for JetPack ${JETPACK_VERSION}..." | ||
| if [ "${JETPACK_VERSION}" = "5.0.2" ]; then |
There was a problem hiding this comment.
Repeated 'echo' + 'sudo cp' blocks in the JetPack branches duplicate file-copy logic; consolidate into a helper function or loop to avoid repetitive code and simplify future updates.
Details
✨ AI Reasoning
The added script contains multiple adjacent echo then sudo cp pairs that perform the same logical operation (copy kernel/module/boot files) across the JetPack-specific branches. This repeats the same file-copying business logic in many places, increasing maintenance burden: a future file-path change would require edits in multiple locations. Consolidating the repeated copying into a small helper function or a loop would reduce duplication and chance of inconsistent updates.
🔧 How do I fix it?
Delete extra code. Extract repeated code sequences into reusable functions or methods. Use loops or data structures to eliminate repetitive patterns.
Reply @AikidoSec feedback: [FEEDBACK] to get better review comments in the future.
Reply @AikidoSec ignore: [REASON] to ignore this issue.
More info
Introduce initial support for D401 GMSL, aligning its resolutions with D401 USB