Add support for JetPack 6.2.1 and update Nvidia sources handling - #346
Conversation
…IT over SSH priority
7d37cd9 to
403bb07
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds support for JetPack version 6.2.1 and modifies the download protocol priority in source synchronization scripts from HTTPS to Git.
Changes:
- Added JetPack 6.2.1 version support across documentation and scripts
- Changed source download protocol priority from HTTPS-first to Git-first with HTTPS fallback
- Added new patch files and symbolic links for JetPack 6.2.1
Reviewed changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| setup_workspace.sh | Updated help text to include 6.2.1 version |
| scripts/source_sync_6.x.sh | Swapped protocol order to try Git first, removed trailing symlink creation |
| scripts/source_sync_5.1.2.sh | Changed protocol order to prefer Git over HTTPS |
| scripts/source_sync_5.0.2.sh | Changed protocol order to prefer Git over HTTPS |
| scripts/source_sync_4.6.1.sh | Changed protocol order to prefer Git over HTTPS |
| scripts/setup-common | Added regex pattern support for patch versions and 6.2.1 revision mapping |
| scripts/install_to_kernel.sh | Consolidated version checks and moved common Image copy outside conditional |
| scripts/deploy_kernel.sh | Updated version checks to include 6.0, 6.1, and 6.2.1 |
| scripts/aggregate_kernel_6.x.sh | Added 6.2.1 to valid kernel versions |
| nvidia-oot/6.2.1/* | Created symbolic links to 6.0 patches |
| kernel/kernel-jammy-src/6.2.1/* | Added patch files for 6.2.1 kernel |
| build_all.sh | Added --clean flag and improved error handling for module copying |
| apply_patches.sh | Added git commit tracking and nvethernetrm symlink creation |
| README_JP6.2.md | Added 6.2.1 to supported JetPack versions |
| README.md | Added 6.2.1 to supported JetPack versions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| fi | ||
|
|
||
| echo "sudo cp boot/Image /boot/${FOLDER}/." | ||
| sudo cp boot/Image /boot/${FOLDER}/. |
There was a problem hiding this comment.
Moved 'sudo cp boot/Image /boot/${FOLDER}/.' outside version checks, making the Image copy unconditional. Restore the copy into the appropriate JetPack-version branch or guard it with the same version conditional.
Details
✨ AI Reasoning
The change moved the kernel Image copy (the command that copies boot/Image into /boot/${FOLDER}) out of the version-specific conditional and into unconditional execution. This alters control flow so the Image is always copied regardless of JETPACK_VERSION, potentially bypassing previous version-specific behavior. Such an unconditional action may have been unintended and can cause incorrect files to be installed on unsupported JetPack versions. The rest of the script logic and echoes remain unchanged; the only behavioral change introduced is the unconditional copy.
🔧 How do I fix it?
Remove debugging statements like console.log, debugger, dd(), or logic bypasses like || true. Keep legitimate logging for monitoring and error handling.
Reply @AikidoSec feedback: [FEEDBACK] to get better review comments in the future.
Reply @AikidoSec ignore: [REASON] to ignore this issue.
More info
Show Fix
Remediation - low confidence
This patch mitigates the unconditional kernel Image copy bypass by restoring the command to execute only within the JetPack 6.x version conditional block.
| fi | |
| echo "sudo cp boot/Image /boot/${FOLDER}/." | |
| sudo cp boot/Image /boot/${FOLDER}/. | |
| echo "sudo cp boot/Image /boot/${FOLDER}/." | |
| sudo cp boot/Image /boot/${FOLDER}/. | |
| fi |
Introduce support for JetPack version 6.2.1, including updates to the documentation and scripts to reflect the new version. Adjust the source download protocol to prioritize Git over HTTPS.
6.2.1 is compilation only - not tested yet on Jetson.