Tracked-on RSDSO 21089: Device did not reset after executing the hardware reset script. - #347
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for JetPack 6.2.1 and implements hardware reset functionality with recovery for GMSL connections.
Changes:
- Added JetPack 6.2.1 support across multiple build/deployment scripts and configuration files
- Implemented hardware reset with recovery mechanism for D4XX devices over GMSL connections
- Enhanced build scripts with clean option and improved error handling
- Added patch management improvements for better version control
Reviewed changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| setup_workspace.sh | Added 6.2.1 to supported JetPack versions list |
| scripts/source_sync_*.sh | Changed git protocol order (git:// first, https:// fallback) |
| scripts/setup-common | Added 6.2.1 version detection and revision mapping |
| scripts/install_to_kernel.sh | Extended version support to include 6.0, 6.1, 6.2, 6.2.1 |
| scripts/deploy_kernel.sh | Extended version support to include 6.0, 6.1, 6.2, 6.2.1 |
| scripts/aggregate_kernel_6.x.sh | Added 6.2.1 to valid kernel versions |
| nvidia-oot/6.2.1/*.patch | Created symlinks and new patches for 6.2.1 support |
| kernel/realsense/d4xx.c | Implemented hardware reset with recovery mechanism |
| kernel/kernel-jammy-src/6.2.1/*.patch | Added kernel patches for 6.2.1 support |
| build_all.sh | Added --clean flag and improved error handling |
| apply_patches.sh | Enhanced patch management with commit tracking |
| README*.md | Updated documentation to include 6.2.1 |
Comments suppressed due to low confidence (1)
kernel/realsense/d4xx.c:1
- Double semicolon found. Remove the extra semicolon.
// SPDX-License-Identifier: GPL-2.0
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+113
to
+122
| cp $KERNEL_MODULES_OUT/kernel/drivers/iio/buffer/kfifo_buf.ko $KERNEL_MODULES_OUT/extra/ || true | ||
| cp $KERNEL_MODULES_OUT/kernel/drivers/iio/buffer/industrialio-triggered-buffer.ko $KERNEL_MODULES_OUT/extra/ || true | ||
| cp $KERNEL_MODULES_OUT/kernel/drivers/iio/common/hid-sensors/hid-sensor-iio-common.ko $KERNEL_MODULES_OUT/extra/ || true | ||
| cp $KERNEL_MODULES_OUT/kernel/drivers/hid/hid-sensor-hub.ko $KERNEL_MODULES_OUT/extra/ || true | ||
| cp $KERNEL_MODULES_OUT/kernel/drivers/iio/accel/hid-sensor-accel-3d.ko $KERNEL_MODULES_OUT/extra/ || true | ||
| cp $KERNEL_MODULES_OUT/kernel/drivers/iio/gyro/hid-sensor-gyro-3d.ko $KERNEL_MODULES_OUT/extra/ || true | ||
| cp $KERNEL_MODULES_OUT/kernel/drivers/iio/common/hid-sensors/hid-sensor-trigger.ko $KERNEL_MODULES_OUT/extra/ || true | ||
| # RealSense cameras support | ||
| cp $KERNEL_MODULES_OUT/kernel/drivers/media/usb/uvc/uvcvideo.ko $KERNEL_MODULES_OUT/extra/ | ||
| cp $KERNEL_MODULES_OUT/kernel/drivers/media/v4l2-core/videodev.ko $KERNEL_MODULES_OUT/extra/ | ||
| cp $KERNEL_MODULES_OUT/kernel/drivers/media/usb/uvc/uvcvideo.ko $KERNEL_MODULES_OUT/extra/ || true | ||
| cp $KERNEL_MODULES_OUT/kernel/drivers/media/v4l2-core/videodev.ko $KERNEL_MODULES_OUT/extra/ || true |
There was a problem hiding this comment.
The cp commands with '|| true' suppress all errors. If these kernel modules are critical for functionality, consider logging which files are missing or adding a check to warn when files cannot be copied. This would improve debugging when builds fail silently.
Collaborator
|
@ymodlin - please mention which JIRA is it related to |
ymodlin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.