Ignore scripts/, CLAUDE.md, .gitignore in auto-tag filter by ymodlin · Pull Request #373 · realsenseai/realsense_mipi_platform_driver

ymodlin · 2026-02-20T12:13:28Z

Summary

Adds scripts/, CLAUDE.md, and .gitignore to the ignored paths in the auto-tag version bump workflow
These files don't represent meaningful driver changes and shouldn't trigger a version bump

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Copilot

Pull request overview

This PR adds a new GitHub Actions workflow for automated daily version bumping and introduces Claude Code configuration. The workflow monitors the dev branch for meaningful changes (excluding documentation, tests, CI configs, scripts, and metadata files) and automatically increments the build number in the kernel driver version when changes are detected.

Changes:

Creates an auto-tag workflow that runs daily to check for meaningful driver changes and bump versions accordingly
Adds Claude Code permissions configuration to control allowed/denied commands in the development environment

Reviewed changes

Copilot reviewed 1 out of 1 changed files in this pull request and generated 12 comments.

File	Description
`.github/workflows/auto-tag.yml`	New workflow for automated version bumping on dev branch with filtering for non-driver changes
`.claude/settings.json`	New Claude Code permissions configuration allowing development commands while restricting dangerous operations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-20T12:18:49Z


        # Filter out ignored paths
-        meaningful=$(echo "$changed" | grep -v -E '^(\.claude/|\.github/|test/|docs/)' || true)
+        meaningful=$(echo "$changed" | grep -v -E '^(\.claude/|\.github/|test/|docs/|scripts/|CLAUDE\.md$|\.gitignore$)' || true)


The pattern \.gitignore$ only matches the root-level .gitignore file. If a .gitignore file is added or modified in a non-ignored subdirectory (e.g., kernel/.gitignore, utilities/.gitignore), it will be considered a "meaningful change" and trigger a version bump.

While .gitignore files in already-ignored directories like test/ and scripts/ are correctly excluded (since those directory patterns match first), .gitignore files in other directories would trigger bumps. If the intent is to ignore all .gitignore files regardless of location, consider using a pattern like (^|/)\.gitignore$ or simply \.gitignore (without anchors) to match any path ending with .gitignore.

Suggested change

meaningful=$(echo "$changed" | grep -v -E '^(\.claude/|\.github/|test/|docs/|scripts/|CLAUDE\.md$|\.gitignore$)' || true)

meaningful=$(echo "$changed" | grep -v -E '^(\.claude/|\.github/|test/|docs/|scripts/|CLAUDE\.md$|.*\.gitignore$)' || true)

Copilot · 2026-02-20T12:18:49Z

      id: bump
      run: |
        current="${{ steps.version.outputs.current }}"
        IFS='.' read -r major minor patch build <<< "$current"


The version parsing assumes a 4-part version number (major.minor.patch.build), but there's no validation that the version string actually has 4 parts. If the MODULE_VERSION in d4xx.c has fewer than 4 parts (e.g., "1.0.2"), the read command will leave build empty, and new_build=$((build + 1)) will result in new_build=1 instead of failing. This could silently introduce incorrect version numbers.

Consider adding validation after the IFS read to ensure all four variables are populated, for example:

if [ -z "$major" ] || [ -z "$minor" ] || [ -z "$patch" ] || [ -z "$build" ]; then echo "::error::Version '$current' must have exactly 4 parts (major.minor.patch.build)" exit 1 fi

Suggested change

IFS='.' read -r major minor patch build <<< "$current"

if [ -z "$major" ] || [ -z "$minor" ] || [ -z "$patch" ] || [ -z "$build" ]; then

echo "::error::Version '$current' must have exactly 4 parts (major.minor.patch.build)"

exit 1

fi

Copilot · 2026-02-20T12:18:50Z

      run: |
        current="${{ steps.version.outputs.current }}"
        new_version="${{ steps.bump.outputs.new_version }}"
        sed -i "s/MODULE_VERSION(\"${current}\")/MODULE_VERSION(\"${new_version}\")/" kernel/realsense/d4xx.c


The sed command uses unescaped special regex characters in the replacement pattern. If the version number contains characters that have special meaning in sed's replacement context (like &, /, or \), the sed command could behave unexpectedly. While version numbers typically don't contain such characters, it's a good practice to escape the variables or use a different delimiter.

Consider using a delimiter that won't appear in version strings, or escape the variables properly. For example:

sed -i "s|MODULE_VERSION(\"${current}\")|MODULE_VERSION(\"${new_version}\")|" kernel/realsense/d4xx.c

Using | as the delimiter avoids conflicts with / if it ever appears in version strings.

Suggested change

escaped_new_version=${new_version//&/\\&}

sed -i "s|MODULE_VERSION(\"${current}\")|MODULE_VERSION(\"${escaped_new_version}\")|" kernel/realsense/d4xx.c

Copilot · 2026-02-20T12:18:50Z


        # Filter out ignored paths
-        meaningful=$(echo "$changed" | grep -v -E '^(\.claude/|\.github/|test/|docs/)' || true)
+        meaningful=$(echo "$changed" | grep -v -E '^(\.claude/|\.github/|test/|docs/|scripts/|CLAUDE\.md$|\.gitignore$)' || true)


The PR description states "Adds scripts/, CLAUDE.md, and .gitignore to the ignored paths in the auto-tag version bump workflow", which implies these are being added to an existing workflow. However, this appears to be a new file (based on the diff showing all lines as additions starting from line 1).

If this is indeed a new file, the PR description should clarify that this is creating a new auto-tag workflow that includes these paths in the ignore list, rather than adding them to an existing workflow. If this is modifying an existing file, please verify that the diff is correctly showing the changes.

Copilot · 2026-02-20T12:18:50Z

    - name: Push commit
      if: steps.changes.outputs.has_changes == 'true'
      run: git push origin dev

    - name: Push tag
      if: steps.changes.outputs.has_changes == 'true'
      run: git push origin "${{ steps.bump.outputs.new_tag }}"



The workflow pushes the commit and tag in separate steps (lines 118-124). If the commit push succeeds but the tag push fails, the repository will be in an inconsistent state: the version bump commit exists on the remote, but the corresponding tag doesn't.

Consider combining the push operations into a single step, or add error handling to ensure both succeed or both fail. For example:

git push origin dev && git push origin "$new_tag" || { echo "::error::Failed to push. Repository may be in inconsistent state." exit 1 }

Alternatively, push both in a single command: git push origin dev "$new_tag"

Suggested change

- name: Push commit and tag

if: steps.changes.outputs.has_changes == 'true'

run: |

new_tag="${{ steps.bump.outputs.new_tag }}"

git push origin dev && git push origin "$new_tag" || {

echo "::error::Failed to push commit and tag. Repository may be in inconsistent state."

exit 1

}

Copilot · 2026-02-20T12:18:51Z

The .claude/settings.json file is included in this PR, but the PR description only mentions changes to the auto-tag workflow filter. This file doesn't appear to be related to the stated purpose of the PR (adding ignored paths to the auto-tag workflow).

If this file is being added as part of setting up the Claude Code environment and is unrelated to the auto-tag changes, it should either be in a separate PR or the PR description should be updated to mention it. Including unrelated changes in a single PR makes it harder to review and understand the purpose of each change.

Copilot · 2026-02-20T12:18:51Z

+        meaningful=$(echo "$changed" | grep -v -E '^(\.claude/|\.github/|test/|docs/|scripts/|CLAUDE\.md$|\.gitignore$)' || true)

        if [ -z "$meaningful" ]; then
          echo "Only ignored-folder changes since $tag:"


The comment "Only ignored-folder changes" is misleading because the ignored paths include specific files (CLAUDE.md, .gitignore) in addition to folders. Consider updating to "Only ignored-path changes" or "Only non-meaningful changes" for accuracy.

Suggested change

echo "Only ignored-folder changes since $tag:"

echo "Only ignored-path changes since $tag:"

Copilot · 2026-02-20T12:18:51Z

        new_version="${{ steps.bump.outputs.new_version }}"
        new_tag="${{ steps.bump.outputs.new_tag }}"

        git config user.email "builder@example.com"


The git configuration uses "builder@example.com" as the commit author email. Using "example.com" might cause issues with some git hosting services or organizational policies that validate email domains. Consider using a noreply email address specific to your GitHub organization (e.g., "builder@users.noreply.github.com") or a valid domain email address.

Suggested change

git config user.email "builder@users.noreply.github.com"

Copilot · 2026-02-20T12:18:52Z


 permissions:
  contents: write



The workflow can run concurrently via scheduled runs and manual workflow_dispatch triggers. If two instances run simultaneously, they might:

Both detect the same "latest tag"

Both calculate the same "new version"

Both try to commit and push, leading to conflicts

Consider adding a concurrency group to prevent multiple instances from running simultaneously:

concurrency: group: auto-tag-version-bump cancel-in-progress: false

This ensures only one instance runs at a time, with subsequent triggers queued.

Suggested change

concurrency:

group: auto-tag-version-bump

cancel-in-progress: false

Copilot · 2026-02-20T12:18:52Z

The permissions allow unrestricted ssh * and scp * commands. These wildcards grant very broad access and could potentially be used to access unintended systems or transfer sensitive data. Consider restricting these to specific hosts or patterns that are necessary for the development workflow, for example:

Bash(ssh user@specific-host *)

Bash(scp * user@specific-host:*)

This follows the principle of least privilege and reduces the attack surface if the Claude Code environment were to be compromised.

Suggested change

"Bash(ssh user@specific-host *)",

"Bash(scp * user@specific-host:*)",

Copilot AI review requested due to automatic review settings February 20, 2026 12:13

Copilot started reviewing on behalf of ymodlin February 20, 2026 12:13 View session

ymodlin and others added 2 commits February 20, 2026 14:16

Use PAT_TOKEN for push to bypass ruleset protection

4f0204a

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Ignore scripts/, CLAUDE.md, .gitignore in version bump check

ee99402

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

ymodlin force-pushed the ci/auto-tag branch from e9e8b31 to ee99402 Compare February 20, 2026 12:18

Copilot AI reviewed Feb 20, 2026

View reviewed changes

ymodlin merged commit 8e95a44 into dev Feb 20, 2026
6 checks passed

ymodlin mentioned this pull request Feb 20, 2026

Add auto-tag daily version bump workflow #374

Merged

ymodlin deleted the ci/auto-tag branch May 27, 2026 10:38

Navigation Menu

Uh oh!

Ignore scripts/, CLAUDE.md, .gitignore in auto-tag filter - #373

Ignore scripts/, CLAUDE.md, .gitignore in auto-tag filter#373
ymodlin merged 2 commits into
devfrom
ci/auto-tag

ymodlin commented Feb 20, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 20, 2026

Uh oh!

Copilot AI Feb 20, 2026

Uh oh!

Copilot AI Feb 20, 2026

Uh oh!

Copilot AI Feb 20, 2026

Uh oh!

Copilot AI Feb 20, 2026

Uh oh!

Copilot AI Feb 20, 2026

Uh oh!

Copilot AI Feb 20, 2026

Uh oh!

Copilot AI Feb 20, 2026

Uh oh!

Copilot AI Feb 20, 2026

Uh oh!

Copilot AI Feb 20, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	meaningful=$(echo "$changed" \| grep -v -E '^(\.claude/\|\.github/\|test/\|docs/\|scripts/\|CLAUDE\.md$\|\.gitignore$)' \|\| true)
	meaningful=$(echo "$changed" \| grep -v -E '^(\.claude/\|\.github/\|test/\|docs/\|scripts/\|CLAUDE\.md$\|.*\.gitignore$)' \|\| true)

+        IFS='.' read -r major minor patch build <<< "$current"
+        if [ -z "$major" ] || [ -z "$minor" ] || [ -z "$patch" ] || [ -z "$build" ]; then
+          echo "::error::Version '$current' must have exactly 4 parts (major.minor.patch.build)"
+          exit 1
+        fi


	escaped_new_version=${new_version//&/\\&}
	sed -i "s\|MODULE_VERSION(\"${current}\")\|MODULE_VERSION(\"${escaped_new_version}\")\|" kernel/realsense/d4xx.c

+    - name: Push commit and tag
+      if: steps.changes.outputs.has_changes == 'true'
+      run: |
+        new_tag="${{ steps.bump.outputs.new_tag }}"
+        git push origin dev && git push origin "$new_tag" || {
+          echo "::error::Failed to push commit and tag. Repository may be in inconsistent state."
+          exit 1
+        }

	echo "Only ignored-folder changes since $tag:"
	echo "Only ignored-path changes since $tag:"

+concurrency:
+  group: auto-tag-version-bump
+  cancel-in-progress: false


	"Bash(ssh user@specific-host *)",
	"Bash(scp * user@specific-host:*)",

Uh oh!

Conversation

ymodlin commented Feb 20, 2026

Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants