Max96712 multicamera - #404
Conversation
Signed-off-by: ejgoldik <ehud.joseph.goldik@realsenseai.com>
Signed-off-by: ejgoldik <ehud.joseph.goldik@realsenseai.com>
Signed-off-by: ejgoldik <ehud.joseph.goldik@realsenseai.com>
Signed-off-by: ejgoldik <ehud.joseph.goldik@realsenseai.com>
08d3241 to
f1b5ec3
Compare
sareluzi
left a comment
There was a problem hiding this comment.
PR Review: Max96712 multicamera
This PR adds support for 4 cameras on a single MAX96712 deserializer. Key changes:
- New DT overlay for 4-camera config
- Dynamic pipe allocation in MAX96712 (replaces hardcoded vc_id == pipe_id)
- New
bind_ser_to_dser_pipe/get_ser_pipe_idAPIs external_addr_reassignDT property for MAX9295- MAX96712 reset via register when GPIO not available
MAX_DS5_NUMincreased fromMAX_DSER_NUM * 2to* 4-ENOSRearly-return to avoid pointless retries
14 comments below.
|
13/14 - JP5.1.2 patch symlinks — verify they apply cleanly
|
Signed-off-by: ejgoldik <ehud.joseph.goldik@realsenseai.com>
I had to make it not a link as the base file max96712 differs by a tiny bit between 5.0.1 and 5.1.2 so you can't use a link. Verified it applies correctly. |
Signed-off-by: ejgoldik <ehud.joseph.goldik@realsenseai.com>
…uild helper Tested 2026-04-28 with the post-realsenseai#11 driver: setting force_clk0; on the dser node makes 0x08A0 = 0x24 (FORCE_CLK0_HS bit 5 set) which wedges MAX96712 forward I2C the moment v4l2-ctl --stream-mmap fires; the chip becomes unreachable on its primary I2C bus until a DC power cycle. Same failure class as the previously documented "FORCE_CLK 0x81 harmful" finding from the pre-PR#404 era; the offending bit is 5 (FORCE_CLK0_HS), not just specific full-byte values. Replace the experimental force_clk0; line with a multi-line comment that warns future readers off the property. The avermedia overlay in this tree sets force_clk0; — that pattern does NOT carry over to LI-JAG-ADP-GMSL2-8CH. Also adds scripts/lijag_rebuild_dtbo.sh so iterating on this DT overlay no longer requires running build_stage1_oot.sh (which rebuilds max9296.ko it doesn't need): preprocess + dtc + cp into /boot/, then reboot. A research pass on realsenseai PRs (realsenseai#356, realsenseai#399, realsenseai#404, realsenseai#405, realsenseai#426) confirmed our 6.2 patch series already incorporates all upstream MAX96712-touching fixes. The "NVCSI sees zero frames" symptom we still have is therefore not addressed by any merged upstream PR.
This enables up to four cameras connected at once to the same max96712 deserializer.
Note that as max96712 has 8 video pipes, the user can stream up to 8 streams at once from all cameras connected to the same deserializer (ir left + right count as 1)