mdx_test: Lazily initialize OCaml toplevel #376
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcc32
force-pushed
the
lazy-init-ocaml-toplevel
branch
from
901495f to
3c492e5
Compare
Collaborator
|
Do you mind rebasing this? |
bcc32
force-pushed
the
lazy-init-ocaml-toplevel
branch
from
3c492e5 to
f1e4c32
Compare
This changes the OCaml toplevel to be a lazy value, which is only forced when needed to run tests in an OCaml block. The motivation behind this change is to avoid stderr output from the init process (e.g., errors while registering pretty-printers) spilling into the test executable's output, which can trip up some build tools.
bcc32
force-pushed
the
lazy-init-ocaml-toplevel
branch
from
f1e4c32 to
e16e8cd
Compare
Author
|
Done, thanks for the ping. |
Collaborator
|
Thanks! Do you think it would be possible to add a test case for this? |
Collaborator
|
Also: could you add a change entry? Many thanks! |
Author
|
In trying to come up with a good test, I realized that the original bug we observed was caused by a separate internal Jane Street patch to mdx (for our custom toplevel backend) and could not be reproduced in this repo. I have gone through and refactored the fix to be more specifically tailored for our internal toplevel backend and I think this can be dropped. Thank you for taking a look at this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the OCaml toplevel to be a lazy value, which is only
forced when needed to run tests in an OCaml block.
The motivation behind this change is to avoid stderr output from the
init process (e.g., errors while registering pretty-printers) spilling
into the test executable's output, which can trip up some build tools.