Alternative method for slicing errors in mli_parser #466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Getting the text of the error from odoc-parser's AST means that you end up with the text of the error with leading whitespace removed, unlike what the current mechanism does. However, since the output code doesn't put any indentation in anyway this might not be a problem. The newer parser in odoc 3 will allow the extraction of the text of code blocks verbatim, but it is more restrictive about the sorts of tags that can appear in code blocks, so there's some design work needed before that can be dropped in. |
Collaborator
|
Looks great! Do you mind adding a change entry (or appending your name and PR to the existing one)? |
Collaborator
|
Thanks! |
jonludlam
added a commit
to jonludlam/opam-repository
that referenced
this pull request
Oct 8, 2025
CHANGES: #### Added - Support OCaml 5.4 (realworldocaml/mdx#470, @chetmurthy) #### Changed - Improved implementation of handling of skipped blocks in mli/mld files (realworldocaml/mdx#466, @jonludlam)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is slightly cleaner than #462 I think!
cc @samoht