-
Notifications
You must be signed in to change notification settings - Fork 37
feat(list): display interactive sessions #436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(list): display interactive sessions #436
Conversation
Add Only with sessions toggle bar to display only workflows that have interactive sessions opened.
c64288a to
df9779a
Compare
Add Only with sessions toggle bar to display only workflows that have interactive sessions opened. docs(readme): update local development instructions (reanahub#432) Write more comprehensive docs on how to run REANA-UI locally, especially for macOS developers.
cf9f689 to
b51829c
Compare
Add Only with sessions toggle bar to display only workflows that have interactive sessions opened. docs(readme): update local development instructions (reanahub#432) Write more comprehensive docs on how to run REANA-UI locally, especially for macOS developers.
88b413b to
90cc94a
Compare
Add Only with sessions toggle bar to display only workflows that have interactive sessions opened. docs(readme): update local development instructions (reanahub#432) Write more comprehensive docs on how to run REANA-UI locally, especially for macOS developers.
90cc94a to
dec0c60
Compare
Add Only with sessions toggle bar to display only workflows that have interactive sessions opened. Closes reanahub#435
f09effe to
c4388bb
Compare
Add Only with sessions toggle bar to display only workflows that have interactive sessions opened. Closes reanahub#435
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work well from my brief testing!
| sharedWith: sharedWithFilter, | ||
| sort: sortDir, | ||
| showLoader, | ||
| ...(sessionFilter ? { type: "interactive" } : {}), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any other workflow types in REANA besides 'interactive'? If not, I wonder why this isn't a boolean? Unless more types are planned for the future. Anyone know?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure, I know there is batch and interactive. There might be others types for launching Dask workflows, Jupyter Notebooks etc.
reana-ui/src/pages/workflowList/components/WorkflowSessionFilters.js
Outdated
Show resolved
Hide resolved
reana-ui/src/pages/workflowList/components/WorkflowSessionFilters.js
Outdated
Show resolved
Hide resolved
Add Only with sessions toggle bar to display only workflows that have interactive sessions opened. Closes reanahub#435
c4388bb to
bef9f31
Compare
Add Only with sessions toggle bar to display only workflows that have interactive sessions opened. Closes reanahub#435
bef9f31 to
38c0746
Compare
Add Only with sessions toggle bar to display only workflows that have interactive sessions opened. Closes reanahub#435
38c0746 to
136dd02
Compare
Add Only with sessions toggle bar to display only workflows that have interactive sessions opened.
Closes #435