fix(dask): catch cleanup errors on cluster creation failures#676
Merged
tiborsimko merged 1 commit intoreanahub:masterfrom Apr 13, 2026
Merged
Conversation
tiborsimko
added a commit
to tiborsimko/reana-workflow-controller
that referenced
this pull request
Apr 13, 2026
…b#676) When the creation of Dask Kubernetes resources fails, the cleanup call to delete_dask_cluster() could itself raise RuntimeError. (E.g. when CRDs are not installed.) The error then propagated beyond ApiException and surfaced as a 500 Internal Server Error, instead of providing a meaningful error message. This commit fixes the problem.
tiborsimko
force-pushed
the
fix-dask-cleanup-error-propagation
branch
from
9d44622 to
f577360
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #676 +/- ##
==========================================
+ Coverage 73.55% 73.74% +0.18%
==========================================
Files 17 17
Lines 2004 2007 +3
==========================================
+ Hits 1474 1480 +6
+ Misses 530 527 -3
🚀 New features to boost your workflow:
|
michaelbuchar
approved these changes
Apr 13, 2026
…b#676) When the creation of Dask Kubernetes resources fails, the cleanup call to delete_dask_cluster() could itself raise RuntimeError. (E.g. when CRDs are not installed.) The error then propagated beyond ApiException and surfaced as a 500 Internal Server Error, instead of providing a meaningful error message. This commit fixes the problem.
tiborsimko
force-pushed
the
fix-dask-cleanup-error-propagation
branch
from
f577360 to
abfaad7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the creation of Dask Kubernetes resources fails, the cleanup call to delete_dask_cluster() could itself raise RuntimeError. (E.g. when CRDs are not installed.) The error then propagated beyond ApiException and surfaced as a 500 Internal Server Error, instead of providing a meaningful error message. This commit fixes the problem.