Add support for dominant-baseline attribute - #46
Open
georgefst wants to merge 3 commits into
Open
Conversation
The old bound of 300 is not high enough on GHC 9.6.3. A loose bound has been chosen for the sake of simplicity and to prevent further churn.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Based on #45 for now since I can't easily build otherwise)
I need this in order to process some basic SVGs output by the
diagramslibrary.There are a few things that could maybe be improved. I'm not totally sure about:
text-anchor, as well asalignment-baseline(which is not yet supported by this library)DrawAttributes?DominantBaselineconstructors - are these maybe copied from some source (seemingly not the SVG spec, or MDN)?